Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsce publish doesn't fully support semver... #63461

Closed
busticated opened this issue Nov 20, 2018 · 2 comments
Closed

vsce publish doesn't fully support semver... #63461

busticated opened this issue Nov 20, 2018 · 2 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions

Comments

@busticated
Copy link

hi there 👋

i just tried to publish my extension for the first time and ran into the following:

Error: The version string '1.0.0-alpha.4' doesn't conform to the requirements for a version. It must be one to four numbers in the range 0 to 2147483647, with each number seperated by a period. It must contain at least one non-zero number.

which is odd since i was under the impression that vscode extensions used semver.

from the docs:

You can also specify a complete SemVer compatible version on the command line

(source)

using node-semver, i'm able to verify my version string is valid:

semver = require('semver');
semver.valid('1.0.0-alpha.4') // = '1.0.0-alpha.4'
semver.valid('1.0.0.4') // = null (iow, invalid)
semver.valid('1') // = null (iow, invalid)

(spec)

here's the command i ran:

vsce publish 1.0.0-alpha.4

vsce version: 1.53.0
OS Version: macOS v10.13.6 (high sierra)

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Nov 20, 2018
@busticated
Copy link
Author

ah, this looks related 👉 microsoft/vscode-vsce#148

@roblourens
Copy link
Member

Yes that's the issue tracking this

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

2 participants