Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP has no way to indicating to the server that the active signature has been changed on the client. #64927

Closed
tinaschrepfer opened this issue Dec 12, 2018 · 4 comments
Assignees

Comments

@tinaschrepfer
Copy link
Member

  • User invoke signature help on VS Code (or any client support LSP) and there are multiple matching signatures.
  • User selects a different signature on the client and then starts typing parameter

Expected:
The selected active signature should not change.

Actual:
The selected active signature changes to the first one.

This occurs because there is no mechanism in the LSP for the client to send a message to the server that the active signature has changed.

@vscodebot
Copy link

vscodebot bot commented Dec 12, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@dbaeumer
Copy link
Member

@jrieken I looked at the code and this seems to be a problem already with the VS Code API. I couldn't find a way how we would tell the signature help provider that the user actually has chosen the second signature.

I tested this with TS and it always falls back to the first signature that matches the types parameters regardless which one I selected before.

Anything I am missing?

@jrieken
Copy link
Member

jrieken commented Dec 13, 2018

yes - this is #33413

@dbaeumer
Copy link
Member

Closing as dup then #33413

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants