Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate data in HTML/CSS contribution #66885

Closed
octref opened this issue Jan 22, 2019 · 1 comment
Closed

Handle duplicate data in HTML/CSS contribution #66885

octref opened this issue Jan 22, 2019 · 1 comment
Assignees
@octref
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues on-testplan
Milestone
December/January ...

Comments

@octref
Copy link
Contributor

octref commented Jan 22, 2019

Follow up from #62976 and #64164.

For example, in the SVG spec, there's a lot of attributes that overlap with normal CSS attributes: https://github.com/octref/svg-data.

We should make sure no duplicates show up (or should we?)
@octref octref added feature-request Request for new features or functionality css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues labels Jan 22, 2019
@octref octref added this to the December/January 2019 milestone Jan 22, 2019
@octref octref self-assigned this Jan 22, 2019
@octref
Copy link
Contributor Author

octref commented Jan 28, 2019

This is done as part of the provider interface.

Verifier: Add a custom tag div per instruction here: https://github.com/Microsoft/vscode-html-languageservice/blob/master/docs/customData.md

Make sure no double div show up in completion.

@octref octref closed this as completed Jan 28, 2019
@dbaeumer dbaeumer added the verification-needed Verification of issue is requested label Jan 29, 2019
@octref octref added on-testplan and removed verification-needed Verification of issue is requested labels Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues on-testplan
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
3 participants
@dbaeumer @octref and others