Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON edit doesn't honour indent style #6716

Closed
jrieken opened this issue May 24, 2016 · 1 comment
Closed

JSON edit doesn't honour indent style #6716

jrieken opened this issue May 24, 2016 · 1 comment
Assignees
@aeschli

Comments

@jrieken
Copy link
Member

jrieken commented May 24, 2016 •
edited
Loading

#6657

  • have settings.json indented with spaces
  • run the File Association action
  • the new portion is formatted using tabs

screen shot 2016-05-24 at 10 15 53
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label May 24, 2016
@aeschli aeschli added this to the May 2016 milestone May 25, 2016
@aeschli aeschli changed the title File Association doesn't honour indent style JSON edit doesn't honour indent style May 25, 2016
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label May 25, 2016
@aeschli aeschli removed this from the May 2016 milestone May 25, 2016
@aeschli
Copy link
Contributor

aeschli commented May 25, 2016

Should have taken 'insertSpaces' and 'tabSize' from model.

We removed the feature that 'Configure File Association' adds a settings string due to the unresolved issues with the configuration open in a dirty editor.

@aeschli aeschli closed this as completed May 25, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrieken @aeschli