Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON edit deletes comments #6725

Closed
jrieken opened this issue May 24, 2016 · 4 comments
Closed

JSON edit deletes comments #6725

jrieken opened this issue May 24, 2016 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2016

Comments

@jrieken
Copy link
Member

jrieken commented May 24, 2016

#6657

  • take your personal VS Code configuration file and make everything line comments
  • run the stupid file association action
  • all of you previous (commented out) configuration is deleted
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels May 24, 2016
@aeschli aeschli changed the title File Association action deletes comments JSON edit deletes comments May 25, 2016
@aeschli aeschli added this to the May 2016 milestone May 25, 2016
@aeschli
Copy link
Contributor

aeschli commented May 25, 2016

Note that we removed the feature that 'Configure File Association' adds a settings string due to the unresolved issues with the configuration open in a dirty editor.

@aeschli aeschli removed the important Issue identified as high-priority label May 25, 2016
@aeschli
Copy link
Contributor

aeschli commented May 26, 2016

Currently only verifiable in code. I added a test in jsonEdit.test.ts, line 87.
@jrieken Can verify this matches your scenario. I assume you had everything commented out, also the array brackets.

@aeschli aeschli assigned jrieken and unassigned aeschli May 26, 2016
@jrieken
Copy link
Member Author

jrieken commented May 26, 2016

correct - I had everything commented out

@joaomoreno
Copy link
Member

Verified by code review. Test looks good.

@joaomoreno joaomoreno added the verified Verification succeeded label Sep 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2016
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @aeschli