Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css customData: status not shown #67611

Closed
kieferrm opened this issue Jan 31, 2019 · 3 comments · May be fixed by GarfieldZHU/vscode#1
Closed

css customData: status not shown #67611

kieferrm opened this issue Jan 31, 2019 · 3 comments · May be fixed by GarfieldZHU/vscode#1
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

Testing #67306.

I cannot make status show up in intellisense or hover no matter which value I use.

VS Code version: Code - Insiders 1.31.0-insider (9606490, 2019-01-30T15:15:08.172Z)
OS version: Darwin x64 18.0.0

@octref
Copy link
Contributor

octref commented Jan 31, 2019

Updated schema so status is one of the four:

image

And pushed a fix for not reading property.status (It's reading the old data format, property.data.status).

@octref octref added bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Jan 31, 2019
@octref octref added this to the December/January 2019 milestone Jan 31, 2019
@kieferrm
Copy link
Member Author

This was also an issue (but is being tracked separately. This on is about that the status that I defined for my custom property does not show up in when the property is proposed in IntelliSense or when I use the property in a css file and I hover over it.

@kieferrm kieferrm reopened this Jan 31, 2019
@octref
Copy link
Contributor

octref commented Jan 31, 2019

@kieferrm Schema fix is microsoft/vscode-css-languageservice@a348121 whereas code fix is microsoft/vscode-css-languageservice@27f369f (which is what closed this issue).

And pushed a fix for not reading property.status (It's reading the old data format, property.data.status).

image

@octref octref closed this as completed Jan 31, 2019
@aeschli aeschli added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants