-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide way for extensions to download and install native dependencies #6929
Comments
To handle HTTP proxies correctly, use the https://www.npmjs.com/package/request-light node module. Maybe we need a hook on installation? Or platform dependent extensions? @joaomoreno @egamma |
Have you tried bundling the native dependencies with your extension? I know there are three platforms to consider, but still... The ideal scenario here is that everything your extension needs should be contained in the published package. Everything else should be done by the extension itself. |
@aeschli -- handling HTTP proxies correctly also means checking the VS Code setting for proxies. Shouldn't that be transparent for extensions so they don't get it wrong? |
@joaomoreno -- that's not acceptable for a number of reasons:
|
@joaomoreno -- one other thing to consider is that there isn't any progress shown in VS Code while an extension is downloaded. So, if extensions don't stay reasonable small, the user can have a confusing experience where VS Code looks it isn't doing any work for a long while. |
This would be very valuable for the CppTools extension as well - we're currently bundling native binaries for the language service and debugger integration for every platform we support, and it's getting unwieldy. Being able to acquire only the binaries relevant to the platform would be a big gain for us. |
I would like to know if it has been solved now? |
This would still be very appreciated. For reference dotnet/vscode-csharp#2648 (comment) |
as a user of extensions that need this fixed in the core to allow those extensions to have additional functionality, i would find this feature very helpful if it we to get picked up in teams next backlog grooming. @ |
I'd close this and mark as dupe of #23251 where the story continues... |
/duplicate as suggested by @gilescope |
This is a request for the C# Extension. Essentially, the extension needs platform-specific native binaries in order to function (both for debugging support and OmniSharp for language server support). It does this by acquiring the binaries during the extension's first activation, rather than during installation. So, the user experience for installation is a bit awkward:
To make matters worse, in order to acquire the native dependencies, the extension essentially has to copy code from VS Code in order to handle HTTP proxies correctly (see dotnet/vscode-csharp@b8f01e4).
The text was updated successfully, but these errors were encountered: