-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types/vscode for extension usage #70175
Comments
We might be able to include proposed dts in |
Not sure, not the biggest fan because proposed api changes a lot and proposed api doesn't work with vscode-stable, only insiders. having it out and published might send the wrong mesage |
@jrieken And I assume we don't publish types for recovery build, such as 1.32.1, correct? |
Yeah, we shouldn't as the API doesn't change |
We'll publish 1.14 to 1.32
Other tracking:
|
@jrieken I plan to update the extension generator, so the template uses latest Do you feel there's a need for vsce to check that the downloaded |
Yeah, that's something something you get for free today and something we loose with the decoupling work. Yeah, I think adding a check to vsce and also some package.json validation makes sense. |
This GitHub Action Event seems the right fit for us to automate |
|
No testplan item for this one because we aren't mentioning it publicly. When #71048 is shipped I'll create testplan item for it. Verifier: Create a new extension, drop |
Update:
New system will:
Ref: microsoft/vscode-extension-vscode#147
DefinitelyTyped, question for publishing old versions of types: DefinitelyTyped/DefinitelyTyped#33738
Tracking here for testing later.
Current Problem:
vscode.d.ts
is fetched by running a script,node_modules/vscode/install
vscode
moduleProposed solution:
@types/vscode
corresponding to the VS Code version. For example VS Code 1.32.0 =>@types/vscode@1.32.0
"@types/vscode": "^1.32.0"
and always get latest API.VS Code related changes:
Extension authors can use
engines.vscode
to specify which versions of VS Code their extensions support. With this change,engines.vscode
is no long used for fetching corresponding dts files.I think this is a good change. I want to develop always with latest
vscode.d.ts
but if I don't use any new API, I can still support older versions. If I want to lock to specific versions ofvscode.d.ts
I can always use exact version such as"@types/vscode": "1.32.0"
.The text was updated successfully, but these errors were encountered: