Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to determine if terminal modification is "allow" or "disallow" #70663

Closed
ssilverman opened this issue Mar 17, 2019 · 2 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label

Comments

@ssilverman
Copy link

ssilverman commented Mar 17, 2019

There's this new mysterious "Do you allow this workspace to modify your terminal shell?" message that happens whenever any action is done in VSCode (I'm using PlatformIO).
(See #68032 for more questions about this, but it doesn't answer the questions posed here.)

When clicking "allow" or "disallow", some state is changed somewhere for the current project. There's no way to determine what the state is after one of the choices is made. Note that a choice can also be made using the Command Palette.

To summarize:

  1. How to determine the current state?

Related:

  1. How to change the state so that the dialog asks again after a choice is made? Completely recreating the project doesn't change the state. It somehow remembers what was chosen last and never asks again.
  2. What is the effect of "allow" vs. the effect of "disallow"? Does it change some terminal setting somewhere outside of VSCode, or does it affect something within only VSCode?
  3. Is it possible to document this more fully? For example, inside one of the settings.json areas.

VSCode version: 1.32.3
OSX version: 10.14.3

@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2019

How to determine the current state?

There are 3 states: allowed, disallowed or not answered. There is no easy way to query the state.

How to change the state so that the dialog asks again after a choice is made?

You cannot unless you change the workspace folder's path. There are these actions though:

image

What is the effect of "allow" vs. the effect of "disallow"?

allow will allow the use of the terminal.integrated.*.env|shell|shellArgs settings, disallow will prevent it (the default).

Is it possible to document this more fully? For example, inside one of the settings.json areas.

It's intentionally not a setting as we don't want to pollute your user settings with a bunch of workspace folders that you allowed. It's meant to be lightweight and answer once and forget about it sort of option. If you have suggestions on improvements to the dialog or something I'm all ears 😃

@Tyriar Tyriar added info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label labels Mar 23, 2019
@vscodebot vscodebot bot closed this as completed Apr 8, 2019
@vscodebot
Copy link

vscodebot bot commented Apr 8, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants