Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode should be aware it might have been called via electron binary #72298

Closed
FFY00 opened this issue Apr 14, 2019 · 5 comments
Closed

VSCode should be aware it might have been called via electron binary #72298

FFY00 opened this issue Apr 14, 2019 · 5 comments
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-os-integration Native OS integration issues

Comments

@FFY00
Copy link

FFY00 commented Apr 14, 2019

Related to #56686

When we start the app using the electron binary, vscode isn't able to properly spawn other instances of itself. This happens because it just uses the binary file to spawn the new session, not taking into account that it might have been started using the electron binary. Vscode just needs to take that into account, it should only add a few lines to the code at most.

@bpasero
Copy link
Member

bpasero commented Apr 16, 2019

//cc @joaomoreno

@bpasero bpasero added feature-request Request for new features or functionality workbench-os-integration Native OS integration issues labels Apr 16, 2019
@bpasero bpasero removed their assignment Apr 16, 2019
@FFY00
Copy link
Author

FFY00 commented May 19, 2019

Any news?

@FFY00
Copy link
Author

FFY00 commented Jun 5, 2019

BUMP

This really shouldn't be a hard fix, I would send a PR myself but I am not very acquainted with the electron codebase.

@Tyriar
Copy link
Member

Tyriar commented Aug 13, 2019

If you can find the lines that need to be changed we will consider it provided it doesn't harm our development flow, but this is basically the same issue as #56686 which was closed as out of scope.

@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Aug 13, 2019
@vscodebot
Copy link

vscodebot bot commented Aug 13, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-os-integration Native OS integration issues
Projects
None yet
Development

No branches or pull requests

3 participants