-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode should be aware it might have been called via electron binary #72298
Comments
//cc @joaomoreno |
Any news? |
BUMP This really shouldn't be a hard fix, I would send a PR myself but I am not very acquainted with the electron codebase. |
If you can find the lines that need to be changed we will consider it provided it doesn't harm our development flow, but this is basically the same issue as #56686 which was closed as out of scope. |
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding and happy coding! |
Related to #56686
When we start the app using the electron binary, vscode isn't able to properly spawn other instances of itself. This happens because it just uses the binary file to spawn the new session, not taking into account that it might have been started using the electron binary. Vscode just needs to take that into account, it should only add a few lines to the code at most.
The text was updated successfully, but these errors were encountered: