Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird 1px black border at bottom [Win10] #74047

Closed
kanlukasz opened this issue May 21, 2019 · 5 comments
Closed

Weird 1px black border at bottom [Win10] #74047

kanlukasz opened this issue May 21, 2019 · 5 comments
Assignees
@bpasero
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@kanlukasz
Copy link

kanlukasz commented May 21, 2019 •
edited
Loading

Hello,

I'm sorry to bother you with low priority bugs, but it's a really annoying visual bug.
In Win 10 i have weird 1px black border at VSCode bottom
It happen when Window: Title Bar Style is set to Custom

Screen below:
obraz

And yes, it's a duplicate but all tickets are closed and it's still not fixed

Version: 1.34.0 (system setup)
Commit: a622c65b2c713c890fcf4fbf07cf34049d5fe758
Date: 2019-05-15T21:59:37.030Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

Insider version: the same problem

Steps to Reproduce:

  1. Run vs code
  2. Maximize windows

Does this issue occur when all extensions are disabled?: YES
@bpasero
Copy link
Member

bpasero commented May 22, 2019

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

@bpasero bpasero added the info-needed Issue requires more information from poster label May 22, 2019
@kanlukasz
Copy link
Author

Thank you for your reply. Unfortunately the same situation, screen below:

[Win 10]
obraz

@bpasero bpasero added electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels May 23, 2019
@kanlukasz kanlukasz mentioned this issue Jun 26, 2019
Closed
18 tasks
@kanlukasz
Copy link
Author

kanlukasz commented Jul 6, 2019 •
edited
Loading

Old references to this problem:

Electron repo:

@kanlukasz
Copy link
Author

Wow, after the last release of Insiders there is no strange border !!!!!
Great news, I hope this will be fixed permanently

obraz

@kanlukasz
Copy link
Author

Update:

With version:

Version: 1.39.0-insider
Commit: 575062278d181c075ea8dce345ab3d20a127309c
Date: 2019-09-20T06:11:13.647Z
Electron: 6.0.9
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

was OK

but

with another update:

Version: 1.39.0-insider
Commit: 79978f96d3501f14b235ed0a33a7360772a726a3
Date: 2019-09-30T14:18:14.941Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

the problem is back 😥

@kanlukasz kanlukasz mentioned this issue Oct 2, 2019
Closed
@bpasero bpasero closed this as completed Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @kanlukasz