Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: Emoji layout is not correct on Windows 10 1903 #74314

Closed
fcharlie opened this issue May 25, 2019 · 2 comments
Closed

Terminal: Emoji layout is not correct on Windows 10 1903 #74314

fcharlie opened this issue May 25, 2019 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@fcharlie
Copy link

  • VSCode Version:
:: code --version
1.34.0
a622c65b2c713c890fcf4fbf07cf34049d5fe758
x64
  • OS Version:
:: cmd ver
Microsoft Windows [版本 10.0.18362.145]

I have a simple code to verify that the terminal supports displaying emoji. Visual Studio Code 1.34 does display emoji on Windows 10 1903, but the layout of emoji is confusing, which is characterized by insufficient character width or partial garbled display.

The complete example can clone fcharlie/bela and then use cmake to build and run the corresponding fmt_test.exe.

The final output uses WriteConsoleW: https://github.com/fcharlie/bela/blob/master/src/bela/stdwriter.cc

Windows Terminal commitid: 4c47631bf4aa907aad4f7088bc7edc7e5cde11b9 In addition to some emoji is too small, other emoji displays are correct. As shown below:

image

Visual Studio Code shows that emoji is confusing:
image

The errors between Terminus and Visual Studio Code are the same as the following:
image

Does this issue occur when all extensions are disabled?: Yes/No

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label May 25, 2019
@fcharlie
Copy link
Author

@Tyriar This should be the problem caused by xterm.js.

@Tyriar
Copy link
Member

Tyriar commented May 31, 2019

Unicode version detection is tricky, this is tracked in xtermjs/xterm.js#1709

@Tyriar Tyriar closed this as completed May 31, 2019
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) *duplicate Issue identified as a duplicate of another issue(s) labels May 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants