Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-line decorations in the minimap #76133

Closed
mjbvz opened this issue Jun 25, 2019 · 2 comments
Closed

Support multi-line decorations in the minimap #76133

mjbvz opened this issue Jun 25, 2019 · 2 comments
Assignees
@RMacfarlane
Labels
editor-minimap Code/Text minimap widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 25, 2019

Testing #76030

Repo

  1. Enable minimap
  2. Open a file
  3. Search for \n with regular expressions enabled

bug
The entire minimap becomes orange:

Screen Shot 2019-06-25 at 12 00 43 PM
@gregvanl
Copy link

gregvanl commented Jun 25, 2019 •
edited
Loading

Yep, something odd with \n and regex. If you search for text with trailing \n, the minimap shows the beginning non-matching part of the line highlighted, not the actual matched string.

image

@RMacfarlane
Copy link
Contributor

Nice catch! I'm not correctly handling multi-line decorations. Will defer this to next iteration, since the I think the fix will be more involved

@RMacfarlane RMacfarlane changed the title Searching for \n regular expression causes entire minimap to be highlighted Support multi-line decorations in the minimap Jul 8, 2019
@RMacfarlane RMacfarlane added this to the July 2019 milestone Jul 8, 2019
@RMacfarlane RMacfarlane added editor-minimap Code/Text minimap widget issues verification-needed Verification of issue is requested labels Jul 8, 2019
@kieferrm kieferrm mentioned this issue Jul 10, 2019
Closed
29 tasks
@jrieken jrieken added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
editor-minimap Code/Text minimap widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@jrieken @RMacfarlane @gregvanl @mjbvz