Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursorSurroundingLines causes text to be selected when clicking near the region #79934

Closed
miguelsolorio opened this issue Aug 27, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@miguelsolorio
Copy link
Contributor

Testing #79834

gif

Steps:

  1. Set editor.cursorSurroundingLines to something like 7
  2. Attempt to click on the last line that is in view in the editor (ensure there are more lines below)
  3. 🐛 Clicking will select the region of text and scroll to the point
@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Aug 27, 2019

Note that on a trackpad a "tap" does not trigger this but a hard "click" does.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 27, 2019
@gregvanl
Copy link

If I click below the cursor, single click works as expected and sets the cursor on the correct text and scrolls up cursorSurroundingLines. However if I double-click, the location is lost and lots of text is selected. This is on Windows 10.

@rebornix
Copy link
Member

Good catch! I played with @gregvanl yesterday together and didn't reproduce this with single click or tap on both Windows and macOS. I'm wondering if it's because a hard click triggers two clicks (tap first and then click) and we scroll the screen in between.

#79935 can probably be a solution to this issue

@rebornix
Copy link
Member

rebornix commented Sep 3, 2019

I pushed a change to ignore single mouse/touchpad clicking in the surrounding area as it will trigger a scroll and then lead to selection. Let's see how it works once we ship Stable and have a Insiders build from master.

@rebornix rebornix closed this as completed Sep 3, 2019
@rebornix rebornix added this to the September 2019 milestone Sep 3, 2019
@mjbvz mjbvz added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants