Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enum dropdown for configuration arrays in settings UI #80537

Closed
letmaik opened this issue Sep 8, 2019 · 4 comments
Closed

Support enum dropdown for configuration arrays in settings UI #80537

letmaik opened this issue Sep 8, 2019 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@letmaik
Copy link
Member

letmaik commented Sep 8, 2019

     "myext.option": {
          "type": "array",
          "items": {
            "type": "string",
            "enum": [
              "A",
              "B"
            ]
          }
      }

Currently (1.38), the settings UI only shows an enum dropdown when the setting is not an array. In the example above only an "Add Item" button is shown with free-text input. A dropdown would be better.

@vscodebot
Copy link

vscodebot bot commented Sep 8, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@letmaik
Copy link
Member Author

letmaik commented Sep 8, 2019

@chrmarti The vscodebot shouldn't suggest duplicate issues if they are from the same author (myself). It's quite unlikely that this would happen.

@chrmarti
Copy link
Collaborator

chrmarti commented Sep 9, 2019

@letmaik Good point, adding it to the bot's issues. Thanks.

@octref
Copy link
Contributor

octref commented Sep 11, 2019

Duplicate of #77458.

@octref octref closed this as completed Sep 11, 2019
@octref octref added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants