Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rush node_modules autocomplete fail #80743

Closed
totomakers opened this issue Sep 11, 2019 · 2 comments
Closed

Rush node_modules autocomplete fail #80743

totomakers opened this issue Sep 11, 2019 · 2 comments
Assignees
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@totomakers
Copy link

totomakers commented Sep 11, 2019

  • VSCode Version: 1.38.0
  • OS Version: Windows_NT x64 (10.0.17134)

Steps to Reproduce:

  1. Clone https://github.com/RDeluxe/rush-repro-955
  2. Go to libraries/dtos/src/dtos/user.ts
    You will have a compiler error. Normally vscode should be able to auto import the missing decorators from class-validator

Additional informations:

Rush strategy is to create a clean node_modules tree in /common/temp/node_modules.
After that rush create for each "packages" a new node_modules tree with symlink.

Imgur

@vscodebot
Copy link

vscodebot bot commented Sep 11, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@mjbvz mjbvz self-assigned this Sep 11, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 14, 2019

This feature is powered by the TypeScript project. Please file a bug report upstream

(Although this may be a duplicate of microsoft/TypeScript#28689)

@mjbvz mjbvz closed this as completed Sep 14, 2019
@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Sep 14, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants