Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom view item tooltips with a richer UI with the markdown support (like hovers) #84032

Closed
eamodio opened this issue Nov 6, 2019 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tree-views Extension tree view issues
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Nov 6, 2019

Currently the tooltip support on custom view items is limited to browser title attribute rendering. It would be great to replace that native tooltip support with a much richer UI -- maybe similar to hovers. This richer UI would support markdown just like hovers do today,

This would allow extensions like GitLens to provide a rich hover over custom view items, just like the blame hovers in the editor -- which would enable, links, commands, and just much richer formatting.

Here is a hover for commit 9f40bf03:
image

Here is the same tooltip for that same commit:
image

In the hover, there are links to email the user, open the PR, etc. Where as none of that is possible in the tooltip.

@eamodio eamodio added feature-request Request for new features or functionality tree-views Extension tree view issues labels Nov 6, 2019
@eamodio
Copy link
Contributor Author

eamodio commented Dec 5, 2019

Related, I would also really like these more advanced "hovers" to have a call back for when they would be shown. Because right now in GitLens, I sometimes have to make expensive calls when creating tree items, just to fill out the tooltip that is unlikely to be used (at least in relation to all the tree items).

@eamodio
Copy link
Contributor Author

eamodio commented Dec 5, 2019

Here is a use-case for this and a dynamic callback. I'm adding a new feature to GitLens to provide the Pull Request which introduced a commit (if any), and I would love to have that information in the hover/tooltip of the commit nodes in the tree, but that query is far too expensive to run on every commit and the current tooltip doesn't provide any good way to interact with the information (e.g. click on a link to jump to the PR)

@sandy081 sandy081 assigned alexr00 and unassigned sandy081 Dec 6, 2019
@sandy081 sandy081 added this to the Backlog Candidates milestone Dec 6, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

1 similar comment
@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@vscodebot
Copy link

vscodebot bot commented Mar 16, 2020

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@tbennun
Copy link

tbennun commented Jul 16, 2020

Would inline images work as well?

@alexr00
Copy link
Member

alexr00 commented Jul 17, 2020

Duplicate of #100741, since that's where the work happened.

The markdown supports everything that the document hovers support.

@alexr00 alexr00 closed this as completed Jul 17, 2020
@alexr00 alexr00 added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

4 participants