Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylistics sets not working properly (Fira Code) #84917

Closed
pierredarrieutort opened this issue Nov 15, 2019 · 11 comments
Closed

Stylistics sets not working properly (Fira Code) #84917

pierredarrieutort opened this issue Nov 15, 2019 · 11 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@pierredarrieutort
Copy link

Hi,

When i use the ligatures codes starting by ss the ligatures are not considered.
Only the stylistics sets like zero or onum working. The other way around for some others (like the Fira code repo owner (third referral)

And when we push another value than true to editor.fontLigatures in settings no one ligatures work.

Refs :


  • VSCode Version: 1.40.1
  • OS Version: Windows 10, 64-bit
@vscodebot
Copy link

vscodebot bot commented Nov 15, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@nkempe
Copy link

nkempe commented Nov 15, 2019

Same on Linux, so it seems OS independent.

Tried without the single quotes:

    "editor.fontFamily": "'Fira Code'",
    "editor.fontLigatures": "ss01, ss02",

..which made no difference, it keeps the >= symbol with the diagonal line instead of the flat line:
image

OS: Ubuntu 18.04
VScode 1.40.1
fonts-firacode version: 1.204-2 installed from ubuntu universe repository

@wboka
Copy link

wboka commented Nov 15, 2019

I'm seeing this issue with the following version combinations:

VS Code v1.40.0 and v1.40.1

Fira Code v2.0

OS Windows 10, 64-bit

@pierredarrieutort
Copy link
Author

@wboka It's not a version combination problem i think, because the font added ligatures characters in the v2.0 and VS Code implemented this editable setting at 1.40.0 (Refer to second link in first post)

@ArturoDent
Copy link

ArturoDent commented Nov 15, 2019

See #84018

and using Fira Code v2 (v1 doesn't support stylistic sets)!

Try adding calt to your list.

"editor.fontLigatures": "'zero', 'ss02', 'ss03', 'ss04', 'ss05', 'calt'",

[You might also try adding liga as well to the list, although I didn't have to.]

Bit of a hidden gotcha IMO. This works for me, it didn't without the calt:

"editor.fontFamily": "Fira Code",
"editor.fontLigatures":"'zero', 'ss02', 'ss03', 'ss04', 'ss05', 'calt'",

firaLIGATURES

And definitely try a reload between changes.

@wboka
Copy link

wboka commented Nov 15, 2019

@ArturoDent Doesn't seem to change anything.

"editor.fontLigatures": "'ss01', 'ss02', 'ss03', 'ss04', 'ss05', 'ss06', 'ss19', 'ss20', 'calt'"

@pierredarrieutort
Copy link
Author

The only visible changement is when i add calt to the array, the ligatures are okay but not the horizontal bar of ss02 ligature

image

@ArturoDent
Copy link

Just in case: I did first delete the Fira Code v1 fonts before installing v2. I would suggest doing that again.

@alexdima
Copy link
Member

@pierredarrieutort Have you uninstalled the previous Fira Code? Restarted, and then installed the new Fira Code?

@alexdima alexdima added the info-needed Issue requires more information from poster label Nov 18, 2019
@pierredarrieutort
Copy link
Author

pierredarrieutort commented Nov 18, 2019

I feel bad now, it was a problem to update the font, a fresh install resolved my problems.

@wboka
Copy link

wboka commented Nov 18, 2019

I had some old versions (v1.206 & v2.0) of the font installed along side each other. 🤦‍♂

Thanks for the help everyone! 🎉

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants