Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons are not properly rendered in embedded terminal #85114

Closed
jfernandz opened this issue Nov 19, 2019 · 2 comments
Closed

Icons are not properly rendered in embedded terminal #85114

jfernandz opened this issue Nov 19, 2019 · 2 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jfernandz
Copy link

jfernandz commented Nov 19, 2019 •
edited
Loading

  • VSCode Version: 1.40.1 8795a9889db74563ddd43eb0a897a2384129a619 x64
  • OS Version: Linux 5.3.11-zen1-1-zen x86_64 GNU/Linux

Steps to Reproduce:

  1. Set your Terminal font in settings
  2. Open the embedded terminal
  3. You will get the following result

Captura de pantalla_2019-11-19_12-42-26

As you can see the icons are cut. I'm not sure if this could be related with video driver, because I have a laptop with an Intel GPU (i915 driver) and it is not showing the issue. I've not tried with a different font but I would like to use that one (DejaVuSansMono Nerd Font).

Does this issue occur when all extensions are disabled?: Yes/No
Yes
@Tyriar
Copy link
Member

Tyriar commented Nov 19, 2019

Unicode width handling tracked in xtermjs/xterm.js#1709

This will probably work with the experimental webgl renderer that just landed in Insiders:

"terminal.integrated.rendererType": "experimentalWebgl"

@Tyriar Tyriar closed this as completed Nov 19, 2019
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 19, 2019
@jfernandz
Copy link
Author

Thank you.

In fact I don't know why I had modified the terminal.integrated.rendererType I've switched it to auto and now is rendering as expected.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @jfernandz