Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open preview action on a markdown file opens the preview again if it is already opened in a different editor group #8581

Closed
sandy081 opened this issue Jun 30, 2016 · 4 comments
Closed

Open preview action on a markdown file opens the preview again if it is already opened in a different editor group #8581

sandy081 opened this issue Jun 30, 2016 · 4 comments
Assignees
@mjbvz
Labels
*as-designed Described behavior is as designed markdown Markdown support issues

Comments

@sandy081
Copy link
Member

  • VSCode Version: a21c123
  • OS Version: OSX

Steps to Reproduce:

  1. Tabs enabled
  2. Open a markdown file
  3. Right click on the tab and open Preview
  4. Drag and drop the opened preview into a second editor group
  5. Right click on the preview tab and open source
  6. Note that it makes already opened markdown file as active
  7. Now again right click on the markdown tab and open Preview

Expected: It makes already opened preview as active
Actual: It opens new Preview tab next to it
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues workbench-tabs VS Code editor tab issues labels Jun 30, 2016
@bpasero bpasero removed the workbench-tabs VS Code editor tab issues label Jul 14, 2016
@mjbvz mjbvz self-assigned this Jan 31, 2017
This was referenced Feb 7, 2017
Closed
Closed
@mjbvz mjbvz modified the milestone: Backlog Feb 23, 2017
@mjbvz mjbvz mentioned this issue Mar 24, 2017
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 4, 2017

Currently blocked by #14483 on implementing this

@kieferrm kieferrm removed their assignment Apr 21, 2017
@mjbvz mjbvz modified the milestones: Backlog, February 2018 Feb 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 26, 2018

Fixed by #44307

@mjbvz mjbvz closed this as completed Feb 26, 2018
@ramya-rao-a
Copy link
Contributor

Running the command Markdown: Open Preview still opens another preview if one exists in another editor group

@ramya-rao-a ramya-rao-a reopened this Mar 1, 2018
@mjbvz mjbvz removed this from the February 2018 milestone Mar 1, 2018
@mjbvz mjbvz added *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Mar 1, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 1, 2018

Sorry, misread the repo instructions. This behavior is actually by-design. Open Preview always opens the preview in the current group. Open preview to side always opens it to the side of the current group. There should only ever be a single preview of a document in a given group at a time

@mjbvz mjbvz closed this as completed Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bpasero @kieferrm @sandy081 @mjbvz @ramya-rao-a