No activations event for file events

[dbaeumer]

Testing #85929

We should have activation events for the provided file events (e.g. onWillRename, ...)

[jrieken]

This needs to go into the textfileservice and(or?) the working copy service

[bpasero]

To clarify: is this about allowing an extension to get activated on the new text file events introduced? Similar to how we activate file system providers for example?

[dbaeumer]

Yes.

[bpasero]

@dbaeumer any thoughts on the naming for such an activation? I assume you would want just one activation for any file operation and not one per kind right?

@jrieken

This needs to go into the textfileservice and(or?) the working copy service

Isn't this the right place? Right before we call $onWillRunFileOperation:

vscode/src/vs/workbench/api/browser/mainThreadFileSystemEventService.ts

Line 59 in 8e66829

return proxy.$onWillRunFileOperation(operation, files, timeout, token);

[dbaeumer]

To ensure that it is not mistaken with file events one idea would be onFileOperation

[bpasero]

@dbaeumer so onFileOperation would be the activation event when:

• onWillCreateFiles
• onWillDeleteFiles
• onWillRenameFiles

Fires?

[dbaeumer]

Yes, I think one is enough. We don't need to distinguish between create, rename and delete.

[jrieken]

Wouldn't the existing onFileScheme:<scheme> be enough? It fires whenever an file is read or written

[bpasero]

Looks like we don't need this.

[dbaeumer]

@bpasero just checking: wouldn't you need to trigger the activation. I assume a delete does neither read nor write the file.

[bpasero]

@jrieken with your undo logic, you now read files before delete to support undo right? So I would expect an activation here.

[bpasero]

I take it back, any IO operation whatsoever will activate the file system provider:

vscode/src/vs/workbench/services/extensions/common/abstractExtensionService.ts

Lines 117 to 119 in d81f0e4

	this._register(this._fileService.onWillActivateFileSystemProvider(e => {
	e.join(this.activateByEvent(`onFileSystem:${e.scheme}`));
	}));

Via

vscode/src/vs/platform/files/common/fileService.ts

Lines 116 to 117 in bb3aaa7

	// Activate provider
	await this.activateProvider(resource.scheme);