Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newest version clobbers window manager keyboard shortcuts #86130

Closed
bjnsn opened this issue Dec 3, 2019 · 8 comments
Closed

Newest version clobbers window manager keyboard shortcuts #86130

bjnsn opened this issue Dec 3, 2019 · 8 comments
Assignees
@deepak1556
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@bjnsn
Copy link

bjnsn commented Dec 3, 2019 •
edited
Loading

Issue Type: Bug

Windows manager ShiftIt no longer controls the window size/position after the most recent version update. Windows of other applications continue to work properly. Changing keyboard shortcuts appears to have no effect. Controlling directly through window manager menu not controlling either. Either shortcuts or menu based control works with common apps such as Chrome, Finder, Firefox, Outlook, Photoshop.

VS Code version: Code 1.40.2 (f359dd6, 2019-11-25T14:52:45.129Z)
OS version: Darwin x64 18.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz (4 x 3400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (1.88GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@IllusionMH
Copy link
Contributor

/cc @deepak1556 can it be related to updated Electron?

@deepak1556
Copy link
Collaborator

@bjnsn can you test with 1.40.1 https://az764295.vo.msecnd.net/stable/8795a9889db74563ddd43eb0a897a2384129a619/VSCode-darwin-stable.zip to confirm if its a regression from electron update. Thanks!

@deepak1556 deepak1556 added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues confirmation-pending electron Issues and items related to Electron electron-6.0.x-update macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 7, 2019
@bjnsn
Copy link
Author

bjnsn commented Dec 9, 2019

@deepak1556 1.40.1 works correctly unlike 1.40.2.

@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member and removed confirmation-pending labels Dec 9, 2019
@deepak1556
Copy link
Collaborator

Thanks for confirming!

@bpasero
Copy link
Member

bpasero commented Dec 12, 2019

@deepak1556 maybe same cause as #84195 ?

@deepak1556
Copy link
Collaborator

@bpasero they are not same, #84195 has been since electron 6.0.0 upgrade and this only started with 1.40.2 and electron 6.1.5 so something in this bump broke.

@bjnsn
Copy link
Author

bjnsn commented Jan 15, 2020

FYI, this appears to have been fixed. My settings with it working are:

Version: 1.41.1
Commit: 26076a4
Date: 2019-12-18T14:57:51.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

@deepak1556 @bpasero should we close this, seems to be fixed?

@bpasero bpasero closed this as completed Jun 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bjnsn @bpasero @deepak1556 @IllusionMH @isidorn