Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad actor extension not cancelling causes flicker #89560

Closed
sbatten opened this issue Jan 28, 2020 · 0 comments
Closed

Bad actor extension not cancelling causes flicker #89560

sbatten opened this issue Jan 28, 2020 · 0 comments
Assignees
@eamodio
Labels
bug Issue identified by VS Code Team member as probable bug timeline Timeline view issues verified Verification succeeded
Milestone
February 2020

Comments

@sbatten
Copy link
Member

sbatten commented Jan 28, 2020

Testing #89385

  1. Make you timeline provider slow (5 seconds or so) and don't cancel if requested.
  2. Test extension and quickly navigate between 2 files in the editor 3 times.

🐛 => the timeline view flickers and reloads 3 times AFTER settling on a file.

It seems we aren't handling our canceling properly?
@eamodio eamodio added the timeline Timeline view issues label Feb 5, 2020
@eamodio eamodio added this to the February 2020 milestone Feb 5, 2020
@eamodio eamodio added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2020
@eamodio eamodio closed this as completed Feb 5, 2020
@sbatten sbatten added the verified Verification succeeded label Feb 27, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Issue identified by VS Code Team member as probable bug timeline Timeline view issues verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@eamodio @sbatten