Hot exit: folders with backups no longer restore

[bpasero]

Steps to Reproduce:

1. open a folder
2. make some files dirty
3. close the window
4. from the command line open code with a different folder

=> 🐛 the folder opens but I would expect a second window opening with the dirty files from the first session

I think this somewhat broke with 7b681aa where I see that we now seem to be adding these folders (looking for backupMainService.getFolderBackupPaths()).

The idea behind hot exit was always that a user would get all sessions with dirty files back as a window when started on a different workspace (@Tyriar correct me if we changed that assumption).

[bpasero]

Was this supposed to be:

foldersToOpen.push(...foldersToRestore.map(f => ({ folderUri: f, remoteAuhority: getRemoteAuthority(f), isRestored: true })));

?

[aeschli]

Yes, you are correct!

[Tyriar]

The idea behind hot exit was always that a user would get all sessions with dirty files back as a window when started on a different workspace

Yes, by default all backed up workspaces would restore whenever VS Code is launched

[bpasero]

This will probably come to a surprise for many people once they update to next stable where we would restore all workspaces with untitled files at once. I find it interesting that no one complained so far, this might backfire :)