Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS 3.9+ should suggest @ts-expect-error directives #92116

Closed
JoshuaKGoldberg opened this issue Mar 5, 2020 · 1 comment · Fixed by #92093
Closed

TS 3.9+ should suggest @ts-expect-error directives #92116

JoshuaKGoldberg opened this issue Mar 5, 2020 · 1 comment · Fixed by #92093
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2020

Comments

@JoshuaKGoldberg
Copy link
Contributor

Following up on microsoft/TypeScript#36014, // @ts-expect-error is now a valid completion directive. It should be recommended over // @ts-ignore in the editor walkthrough that mentions comment directives.
@vscodebot
Copy link

vscodebot bot commented Mar 5, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 5, 2020
Merged
@mjbvz mjbvz added this to the March 2020 milestone Mar 5, 2020
@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues verification-needed Verification of issue is requested labels Mar 5, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

Successfully merging a pull request may close this issue.

Added completion entry for @ts-expect-error directive
3 participants
@connor4312 @JoshuaKGoldberg @mjbvz