Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open File from Cmd Pallette Uses Partial Path while Open from Search Results Uses Full Path #92655

Closed
jkassis opened this issue Mar 13, 2020 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@jkassis
Copy link

jkassis commented Mar 13, 2020

When I open a file using the command palette, it recognizes that the file is relative to my document root.

When I open the file using search results from workspace-wide search, it opens with the full path.

The file opened by search results is then disconnected from the projects... code navigation commands don't work. SETTING BREAKPOINTS DONT WORK. Note that this could explain why some of the breakpoints not working tickets are hard to track down. It may have nothing to do with symlinks.

image

@jkassis
Copy link
Author

jkassis commented Mar 13, 2020

@ramya-rao-a ^^^ Maybe explains why debugger breakpoints don't work sometimes.

@jkassis
Copy link
Author

jkassis commented Mar 13, 2020

more...
image
image
image

@jkassis
Copy link
Author

jkassis commented Mar 13, 2020

maybe vscode needs a special system-wide cap-safe mode for osx?

@bpasero bpasero added search Search widget and operation issues and removed info-needed Issue requires more information from poster labels Mar 16, 2020
@bpasero bpasero assigned roblourens and unassigned bpasero Mar 16, 2020
@bpasero
Copy link
Member

bpasero commented Mar 16, 2020

I think quick open does the right thing but search does not, moving to Rob.

@roblourens
Copy link
Member

Hm, basically you search in folder foo and find file bar and we return foo/bar, there is no case-normalization step. Quickopen would normally do the right thing if Code was opened with the correctly cased workspace folder. But @bpasero I can reproduce the same thing with quickopen's absolute path handling logic -

mkdir Foo
touch Foo/bar

then in quickopen, open ~/folder/Foo/bar and ~/folder/foo/bar, and they open as separate tabs with differently cased paths. As far as I know we don't really do any case normalization anywhere in vscode and this would fall under the master path case issue that we have.

@bpasero
Copy link
Member

bpasero commented Mar 30, 2020

If that is the issue, then it is #12448

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @bpasero @jkassis and others