Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press Enter to manage your extensions doesn't do anything #93949

Closed
Tyriar opened this issue Mar 31, 2020 · 6 comments
Closed

Press Enter to manage your extensions doesn't do anything #93949

Tyriar opened this issue Mar 31, 2020 · 6 comments
Assignees
@sandy081
Labels
extensions Issues concerning extensions quick-pick Quick-pick widget issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93641

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

image

ctrl+p, "ext ", enter

This doesn't do anything, it just keeps flashing?
@Tyriar Tyriar mentioned this issue Mar 31, 2020
Closed
@bpasero bpasero added the quick-pick Quick-pick widget issues label Mar 31, 2020
@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

Does not reproduce for me, but then I wonder why the first item is not selected?

image

@Tyriar do you have accessibility mode on?

@bpasero bpasero self-assigned this Mar 31, 2020
@bpasero bpasero added the info-needed Issue requires more information from poster label Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Mar 31, 2020

Yes I had it on, I thought it was an informational label. If this is just an action to open the view it should say "Manage extensions", there are more ways to trigger it than just enter (touch, click).

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

As for the issue of not selecting that item, we have #93610

I leave it up to @sandy081 to change this label, it was unchanged from stable:

image

@bpasero bpasero removed their assignment Apr 1, 2020
@bpasero bpasero added extensions Issues concerning extensions and removed info-needed Issue requires more information from poster labels Apr 1, 2020
@bpasero bpasero removed this from the March 2020 milestone Apr 1, 2020
@sandy081
Copy link
Member

sandy081 commented Apr 1, 2020

No plans to change.

@sandy081 sandy081 closed this as completed Apr 1, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 1, 2020

Why? We don't tell the user to press enter on any commands in the command palette, right now it's inconsistent with literally every other quick access provider.

@sandy081
Copy link
Member

sandy081 commented Apr 1, 2020

Yah this is an information label and I like this way. There are no pickers like in other cases. Also I did not see any users complained about it.

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
extensions Issues concerning extensions quick-pick Quick-pick widget issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @sandy081