Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Breakpoints updated only after save #9533

Closed
1 task done
isidorn opened this issue Jul 20, 2016 · 1 comment
Closed
1 task done

Test: Breakpoints updated only after save #9533

isidorn opened this issue Jul 20, 2016 · 1 comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 20, 2016

Test for #8077:

New or changed breakpoints are now sent to the debug adapter only after a file has been saved so that they always correspond to the file on disk. Previously breakpoints were sent to the debug adapter immediately even before the file was saved to disk. In this case the debugger would register breakpoints for a source location that only exists in the editor buffer, but not in the file that the runtime sees.

(More details about this feature can be found here: #8077)

Turn auto save off and then launch a node debug session and stop on break.
Then verify:

  • As long as the file is not edited breakpoints should behave normally, e.g. they are shown as verified, they are hit and can be enabled / disabled, deleted.
  • As soon as a file is edited, breakpoints are shown as unverified and the hover message explains why.
  • Once a file is saved breakpoints are still unverified (because node-debug does not yet implement hot-code-replacement). The hover message should be slightly different.
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jul 20, 2016
@isidorn isidorn added this to the July 2016 milestone Jul 20, 2016
@weinand weinand changed the title Breakpoints updated only after save Test: Breakpoints updated only after save Jul 25, 2016
@weinand weinand self-assigned this Jul 25, 2016
@egamma egamma mentioned this issue Jul 25, 2016
89 tasks
@weinand weinand removed their assignment Jul 25, 2016
@sandy081 sandy081 self-assigned this Jul 26, 2016
@sandy081
Copy link
Member

Done with testing. LGTM.

@sandy081 sandy081 removed their assignment Jul 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

3 participants