Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerender cell output in the viewport if the notebook renderer webview reloads #95990

Closed
connor4312 opened this issue Apr 23, 2020 · 1 comment · Fixed by #97282
Closed

Rerender cell output in the viewport if the notebook renderer webview reloads #95990

connor4312 opened this issue Apr 23, 2020 · 1 comment · Fixed by #97282
Assignees
@rebornix @connor4312
Labels
feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2020

Comments

@connor4312
Copy link
Member

Refs: #95908
@connor4312 connor4312 added feature-request Request for new features or functionality notebook labels Apr 23, 2020
@connor4312 connor4312 added this to the April 2020 milestone Apr 23, 2020
@connor4312 connor4312 mentioned this issue Apr 23, 2020
Closed
5 tasks
@connor4312 connor4312 modified the milestones: April 2020, May 2020 Apr 27, 2020
@rebornix rebornix mentioned this issue May 1, 2020
Closed
17 tasks
@connor4312 connor4312 mentioned this issue May 8, 2020
Merged
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jun 3, 2020
@connor4312
Copy link
Member Author

To verify:

  1. Open a notebook and execute some cells
  2. Run the "open webview developer tools command"
  3. Inside the chrome devtools window, hit ctrl+r to refresh the webview
  4. Verify that output is still renderered/displayed

@joaomoreno joaomoreno added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@connor4312 connor4312

Labels
feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

Successfully merging a pull request may close this issue.

notebooks: rerender output if the webview reloads microsoft/vscode
3 participants
@joaomoreno @rebornix @connor4312