Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: input reports dirty even with auto save on #96400

Closed
bpasero opened this issue Apr 28, 2020 · 1 comment
Closed

Notebook: input reports dirty even with auto save on #96400

bpasero opened this issue Apr 28, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 28, 2020

Refs: #96279

You want to copy this behaviour over to your editor input which will hide the dirty indicator when auto save is on.

public isSaving(): boolean {
if (!this.isDirty()) {
return false; // the editor needs to be dirty for being saved
}
if (this.filesConfigurationService.getAutoSaveMode() === AutoSaveMode.AFTER_SHORT_DELAY) {
return true; // a short auto save is configured, treat this as being saved
}
return false;
}

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 28, 2020
@rebornix rebornix added this to the April 2020 milestone Apr 28, 2020
@rebornix
Copy link
Member

Verifier: please validate that when auto save is set to after delay, you don't see the dirty indicator.

@bpasero bpasero added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants