Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal link detection doesn't handle words of non-english characters #96416

Closed
roblourens opened this issue Apr 28, 2020 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Apr 28, 2020

Testing #96299

touch '我是学生.txt'
touch '我是很酷.txt'
ls

If I hover one of those names, only one character is highlighted. I figured words would just be delimited by whitespace and some characters like ()[] etc

@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2020

Good find, I think it's happening because to the right of each wide char is an "empty" char which is probably being interpreted as a space

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 28, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 28, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 29, 2020

Fixed this but there is still a glitch where the underline will show on an extra character, this is in xterm.js deferred to xtermjs/xterm.js#2887

@Tyriar Tyriar closed this as completed in d2e4fab Apr 29, 2020
@mjbvz mjbvz added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants