Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Windows setting is ignored if app opened via Open With Code shortcut #97493

Closed
gitvadim opened this issue May 11, 2020 · 6 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-state UI state across restarts

Comments

@gitvadim
Copy link

Issue Type: Bug

Repro steps:

  1. Set Restore Windows to none,
  2. Open a new Editor
  3. Open a few documents
  4. Close the editor
  5. Right click any folder and select Open with Code

Actual result

The app will open with all the documents that were open before you closed it

Expected result

If Restore Windows is set to none the app should open 'empty' with no documents but scoped to the folder that was right-clicked.

VS Code version: Code 1.45.0 (d69a79b, 2020-05-07T16:18:48.860Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs AMD Ryzen 7 2700X Eight-Core Processor (16 x 3675)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.95GB (16.14GB free)
Process Argv F:\Source\SAM\Def6\imc-uxp\frontend\exhibitor-portal
Screen Reader no
VM 0%
Extensions (12)
Extension Author (truncated) Version
prettier-for-handlebars-vscode alo 2.0.1
Handlebars and 0.4.1
vs-edit-hosts con 0.0.1
dart-code Dar 3.10.1
flutter Dar 3.10.1
xml Dot 2.5.0
vscode-docker ms- 1.1.0
python ms- 2020.4.76186
powershell ms- 2020.4.0
vscode-scss-formatter sib 2.0.1
markdown-pdf yza 1.4.4
markdown-all-in-one yzh 2.8.0

(1 theme extensions excluded)

@bpasero
Copy link
Member

bpasero commented May 11, 2020

@gitvadim where editors dirty in that session or did you use untitled workspaces?

@bpasero bpasero added the info-needed Issue requires more information from poster label May 11, 2020
@gitvadim
Copy link
Author

gitvadim commented May 11, 2020

@bpasero
I did not create any workspaces (at least knowingly); the editor can be dirty but does not have to -- the issue reproduces regardless, if you open the same folder and if you did not manually close the open editors before closing VSCode.

@bpasero
Copy link
Member

bpasero commented May 11, 2020

I cannot reproduce. I need exact steps like I would have never used VSCode before, including keyboard interaction and mouse interaction. Ideally video.

@gitvadim
Copy link
Author

gitvadim commented May 11, 2020

I've attached a video. In the video I'm double-clicking files in VSCode to 'pin' the editor. I had to zip the mp4 file.

video.zip

@bpasero bpasero added the workbench-state UI state across restarts label May 11, 2020
@bpasero
Copy link
Member

bpasero commented May 11, 2020

/duplicate #22613

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-state UI state across restarts
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @gitvadim and others