Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code kept attached to the terminal it was started from #98164

Closed
AnrDaemon opened this issue May 19, 2020 · 6 comments
Closed

VS Code kept attached to the terminal it was started from #98164

AnrDaemon opened this issue May 19, 2020 · 6 comments
Assignees

Comments

@AnrDaemon
Copy link

AnrDaemon commented May 19, 2020

Issue Type: Bug

Start VS Code from a terminal (cmd, bash, Far manager… whatever).
Wait a bit.
VS Code spamming console with logs.
image

It doesn't matter, how you start it, no amount of tricks would help. Even starting through a batch file in a separate console won't help.

VS Code version: Code 1.45.1 (5763d90, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 6.1.7601

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3550 CPU @ 3.30GHz (4 x 3303)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.96GB (5.32GB free)
Process Argv C:\Users\anrdaemon\Documents.github\SimpleCache
Screen Reader no
VM 0%
Extensions (8)
Extension Author (truncated) Version
vscode-intelephense-client bme 1.3.11
gitlens eam 10.2.1
EditorConfig Edi 0.14.5
php-debug fel 1.13.0
todo-tree Gru 0.0.175
smarty imp 0.3.0
svn-scm joh 2.11.1
sqltools mtx 0.21.7
@IllusionMH
Copy link
Contributor

IllusionMH commented May 19, 2020

How exactly are you launching VS Code?
Are you launching code.exe or bin/code.cmd? if it's just code does your PATH contain bin at the end of the VS Code related folder?

Looks similar to # 1369 #73789

@AnrDaemon
Copy link
Author

In most common case, I use shell extension. Which launches code.exe directly as per Windows association.

No, I don't pollute my %PATH% with unnecessary… paths.

The issue you linked seems wholly unrelated. Did you mistype the number?

@IllusionMH
Copy link
Contributor

Yep, correct one is #73789

Which launches code.exe directly

For launches from cmd etc. it should use bin/code.cmd instead of code.exe directly.

@AnrDaemon
Copy link
Author

Why it should? Why can't I use a program and OS like it's supposed to? There's a file type association, and it should behave the same for all intents and purposes.

I can't even get away from it, if I START "" cmd /C "code.exe" Somedir\. The Code.exe mysteriously WILL STILL know what terminal it was started from. Even if I chain multiple cmd.exe's that would die long before code.exe is started. It seems like a dark magic, not an application behaving by the rules of the OS.

@Tyriar Tyriar assigned joaomoreno and unassigned Tyriar Jun 8, 2020
@Tyriar Tyriar removed the terminal Integrated terminal issues label Jun 8, 2020
@Tyriar
Copy link
Member

Tyriar commented Jun 8, 2020

I suspect this is by design, but @joaomoreno might have more ideas.

@joaomoreno
Copy link
Member

joaomoreno commented Jun 9, 2020

@IllusionMH is on the right track. Due to a limitation in Electron, you are forced to use the launcher in our bin folder if you want to run from the command line. This is why we add the bin folder to the PATH instead of exposing Code.exe.

It's not really by design, but by upstream.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @IllusionMH @Tyriar @AnrDaemon and others