New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless check for array in ContextKeyChangeEvent #42914

Merged

jrieken merged 1 commit into microsoft:master from Connormiha:optimize-context-key-change-event

Feb 26, 2018

Contributor

Connormiha commented Feb 4, 2018

Removed check isArray and use concat for both cases, because concat works correct with array and not array as argument.

['mike', 'bob'].concat('alex'); // ['mike', 'bob', 'alex']
['mike', 'bob'].concat(['alex', 'bill']); // ['mike', 'bob', 'alex', 'bill']


          Remove needless check for array in ContextKeyChangeEvent

a75736e

alexdima assigned jrieken

jrieken added this to the February 2018 milestone

jrieken merged commit 43fbb43 into microsoft:master

Member

jrieken commented Feb 26, 2018

Thanks. Learnt something!

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet