Fixes #19580; added copy property path action to debug viewlet #43423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isidorn
reviewed
Feb 13, 2018
| static LABEL = nls.localize('copyPropertyPath', "Copy Property Path"); | ||
|
|
||
| constructor(id: string, label: string, private value: any) { | ||
| super(id, label, 'debug-action copy-property-path'); |
There was a problem hiding this comment.
No need to pass the css class since this action does not have that, simply pass undefined as the third argument
isidorn
reviewed
Feb 13, 2018
| @@ -34,6 +34,23 @@ export class CopyValueAction extends Action { | |||
| } | |||
| } | |||
|
|
|||
| export class CopyPropertyPathAction extends Action { | |||
There was a problem hiding this comment.
CopyEvaluatePathAction is a better name imho
| @@ -34,6 +34,23 @@ export class CopyValueAction extends Action { | |||
| } | |||
| } | |||
|
|
|||
| export class CopyPropertyPathAction extends Action { | |||
| static readonly ID = 'workbench.debug.viewlet.action.copyPropertyPath'; | |||
There was a problem hiding this comment.
Change id to workbench.debug.viewlet.action.copyEvaluatePath'
| export class CopyPropertyPathAction extends Action { | ||
| static readonly ID = 'workbench.debug.viewlet.action.copyPropertyPath'; | ||
| static LABEL = nls.localize('copyPropertyPath', "Copy Property Path"); | ||
|
|
There was a problem hiding this comment.
I would change the label to "Copy Path"
| @@ -179,6 +179,7 @@ class VariablesActionProvider implements IActionProvider { | |||
| const actions: IAction[] = []; | |||
| const variable = <Variable>element; | |||
| actions.push(new SetValueAction(SetValueAction.ID, SetValueAction.LABEL, variable, this.debugService, this.keybindingService)); | |||
| actions.push(new CopyPropertyPathAction(CopyPropertyPathAction.ID, CopyPropertyPathAction.LABEL, variable)); | |||
There was a problem hiding this comment.
Set Value and Copy Value should be first, So CopyEvaluatePathAction should come third
|
@ergun1017 I have commented directly in the code - mostly polish. Once you address all those I can merge this in. Thanks |
|
@ergun1017 good job, thanks a lot 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19580