Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming Close Unmodified to Close Unsaved #44269

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Renaming Close Unmodified to Close Unsaved #44269

merged 2 commits into from
Feb 26, 2018

Conversation

itamark
Copy link
Contributor

@itamark itamark commented Feb 23, 2018

@msftclas
Copy link

msftclas commented Feb 23, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@itamark itamark mentioned this pull request Feb 23, 2018
Closed
@bpasero bpasero self-assigned this Feb 23, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 23, 2018
@bpasero
Copy link
Member

bpasero commented Feb 23, 2018

@itamark note that we cannot change identifiers of actions/commands, because people might have associated keybindings already.

@itamark
Copy link
Contributor Author

itamark commented Feb 23, 2018

@bpasero Oh, good to know. That makes sense. Should I change all instances of CLOSE_SAVED_EDITORS_COMMAND_ID back?

@itamark
Copy link
Contributor Author

itamark commented Feb 23, 2018

@bpasero okay put back the action identifiers.

@itamark
Copy link
Contributor Author

itamark commented Feb 25, 2018 •
edited
Loading

@bpasero kind of looks like the failures are not related to my commit. Is that possible?

@bpasero bpasero merged commit 3f6df1e into microsoft:master Feb 26, 2018
@bpasero
Copy link
Member

bpasero commented Feb 26, 2018 •
edited
Loading

Its fine, I merged it with a follow up change: 8015c58

Thanks 👍

@soneymathew soneymathew mentioned this pull request Mar 9, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@itamark @msftclas @bpasero