diff --git a/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MessageType.cs b/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MessageType.cs index 1afc0e0350..d4564a3c45 100644 --- a/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MessageType.cs +++ b/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MessageType.cs @@ -124,14 +124,14 @@ public static class MessageType public const string CustomTestHostLaunchCallback = "TestExecution.CustomTestHostLaunchCallback"; /// - /// Test session end + /// Multi test runs finalization /// - public const string OnTestSessionEnd = "TestExecution.OnTestSessionEnd"; + public const string MultiTestRunsFinalization = "TestExecution.MultiTestRunsFinalization"; /// - /// Test session end callback + /// Multi test runs finalization callback /// - public const string OnTestSessionEndCallback = "TestExecution.OnTestSessionEnd"; + public const string MultiTestRunsFinalizationCallback = "TestExecution.MultiTestRunsFinalizationCallback"; /// /// Extensions Initialization diff --git a/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/TestSessionCompletePayload.cs b/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MultiTestRunsFinalizationCompletePayload.cs similarity index 78% rename from src/Microsoft.TestPlatform.CommunicationUtilities/Messages/TestSessionCompletePayload.cs rename to src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MultiTestRunsFinalizationCompletePayload.cs index d280d8c44d..457f539d86 100644 --- a/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/TestSessionCompletePayload.cs +++ b/src/Microsoft.TestPlatform.CommunicationUtilities/Messages/MultiTestRunsFinalizationCompletePayload.cs @@ -6,12 +6,11 @@ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.ObjectModel using System.Collections.Generic; using Microsoft.VisualStudio.TestPlatform.ObjectModel; - using Microsoft.VisualStudio.TestPlatform.ObjectModel.Client; /// - /// The test run complete payload. + /// Multi test runs finalization complete payload. /// - public class TestSessionCompletePayload + public class MultiTestRunsFinalizationCompletePayload { /// /// Gets or sets the attachments. diff --git a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/Interfaces/ITestPlatformEventSource.cs b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/Interfaces/ITestPlatformEventSource.cs index 961a9963bb..db84bd3bd6 100644 --- a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/Interfaces/ITestPlatformEventSource.cs +++ b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/Interfaces/ITestPlatformEventSource.cs @@ -184,52 +184,52 @@ public interface ITestPlatformEventSource void MetricsDisposeStop(); /// - /// The session finalization request start. + /// The multi test runs finalization request start. /// - void SessionFinalizationRequestStart(); + void MultiTestRunsFinalizationRequestStart(); /// - /// The session finalization request stop. + /// The multi test runs finalization request stop. /// - void SessionFinalizationRequestStop(); + void MultiTestRunsFinalizationRequestStop(); /// - /// The adapter session finalization start. + /// The adapter multi test runs finalization start. /// /// /// The number of attachements. /// - void AdapterSessionFinalizationStart(long numberOfAttachements); + void AdapterMultiTestRunsFinalizationStart(long numberOfAttachements); /// - /// The adapter session finalization stop. + /// The adapter multi test runs finalization stop. /// /// /// The number of attachements. /// - void AdapterSessionFinalizationStop(long numberOfAttachements); + void AdapterMultiTestRunsFinalizationStop(long numberOfAttachements); /// - /// The session finalization start. + /// The multi test runs finalization start. /// - void SessionFinalizationStart(); + void MultiTestRunsFinalizationStart(); /// - /// The session finalization stop. + /// The multi test runs finalization stop. /// /// /// The number of attachements. /// - void SessionFinalizationStop(long numberOfAttachements); + void MultiTestRunsFinalizationStop(long numberOfAttachements); /// - /// Mark the start of translation layer session finalization request. + /// Mark the start of translation layer multi test runs finalization request. /// - void TranslationLayerSessionFinalizationStart(); + void TranslationLayerMultiTestRunsFinalizationStart(); /// - /// Mark the completion of translation layer session finalization request. + /// Mark the completion of translation layer multi test runs finalization request. /// - void TranslationLayerSessionFinalizationStop(); + void TranslationLayerMultiTestRunsFinalizationStop(); } } diff --git a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformEventSource.cs b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformEventSource.cs index f0444bbde6..edf6846b19 100644 --- a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformEventSource.cs +++ b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformEventSource.cs @@ -239,59 +239,59 @@ public void MetricsDisposeStop() } /// - [Event(TestPlatformInstrumentationEvents.SessionFinalizationRequestStartEventId)] - public void SessionFinalizationRequestStart() + [Event(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationRequestStartEventId)] + public void MultiTestRunsFinalizationRequestStart() { - this.WriteEvent(TestPlatformInstrumentationEvents.SessionFinalizationRequestStartEventId); + this.WriteEvent(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationRequestStartEventId); } /// - [Event(TestPlatformInstrumentationEvents.SessionFinalizationRequestStopEventId)] - public void SessionFinalizationRequestStop() + [Event(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationRequestStopEventId)] + public void MultiTestRunsFinalizationRequestStop() { - this.WriteEvent(TestPlatformInstrumentationEvents.SessionFinalizationRequestStopEventId); + this.WriteEvent(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationRequestStopEventId); } /// - [Event(TestPlatformInstrumentationEvents.AdapterSessionFinalizationStartEventId)] - public void AdapterSessionFinalizationStart(long numberOfAttachements) + [Event(TestPlatformInstrumentationEvents.AdapterMultiTestRunsFinalizationStartEventId)] + public void AdapterMultiTestRunsFinalizationStart(long numberOfAttachements) { - this.WriteEvent(TestPlatformInstrumentationEvents.AdapterSessionFinalizationStartEventId, numberOfAttachements); + this.WriteEvent(TestPlatformInstrumentationEvents.AdapterMultiTestRunsFinalizationStartEventId, numberOfAttachements); } /// - [Event(TestPlatformInstrumentationEvents.AdapterSessionFinalizationStopEventId)] - public void AdapterSessionFinalizationStop(long numberOfAttachements) + [Event(TestPlatformInstrumentationEvents.AdapterMultiTestRunsFinalizationStopEventId)] + public void AdapterMultiTestRunsFinalizationStop(long numberOfAttachements) { - this.WriteEvent(TestPlatformInstrumentationEvents.AdapterSessionFinalizationStopEventId, numberOfAttachements); + this.WriteEvent(TestPlatformInstrumentationEvents.AdapterMultiTestRunsFinalizationStopEventId, numberOfAttachements); } /// - [Event(TestPlatformInstrumentationEvents.SessionFinalizationStartEventId)] - public void SessionFinalizationStart() + [Event(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationStartEventId)] + public void MultiTestRunsFinalizationStart() { - this.WriteEvent(TestPlatformInstrumentationEvents.SessionFinalizationStartEventId); + this.WriteEvent(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationStartEventId); } /// - [Event(TestPlatformInstrumentationEvents.SessionFinalizationStopEventId)] - public void SessionFinalizationStop(long numberOfAttachements) + [Event(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationStopEventId)] + public void MultiTestRunsFinalizationStop(long numberOfAttachements) { - this.WriteEvent(TestPlatformInstrumentationEvents.SessionFinalizationStopEventId, numberOfAttachements); + this.WriteEvent(TestPlatformInstrumentationEvents.MultiTestRunsFinalizationStopEventId, numberOfAttachements); } /// - [Event(TestPlatformInstrumentationEvents.TranslationLayerSessionFinalizationStartEventId)] - public void TranslationLayerSessionFinalizationStart() + [Event(TestPlatformInstrumentationEvents.TranslationLayerMultiTestRunsFinalizationStartEventId)] + public void TranslationLayerMultiTestRunsFinalizationStart() { - this.WriteEvent(TestPlatformInstrumentationEvents.TranslationLayerSessionFinalizationStartEventId); + this.WriteEvent(TestPlatformInstrumentationEvents.TranslationLayerMultiTestRunsFinalizationStartEventId); } /// - [Event(TestPlatformInstrumentationEvents.TranslationLayerSessionFinalizationStopEventId)] - public void TranslationLayerSessionFinalizationStop() + [Event(TestPlatformInstrumentationEvents.TranslationLayerMultiTestRunsFinalizationStopEventId)] + public void TranslationLayerMultiTestRunsFinalizationStop() { - this.WriteEvent(TestPlatformInstrumentationEvents.TranslationLayerSessionFinalizationStopEventId); + this.WriteEvent(TestPlatformInstrumentationEvents.TranslationLayerMultiTestRunsFinalizationStopEventId); } } } diff --git a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformInstrumentationEvents.cs b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformInstrumentationEvents.cs index 1eadce444d..9931100f1c 100644 --- a/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformInstrumentationEvents.cs +++ b/src/Microsoft.TestPlatform.CoreUtilities/Tracing/TestPlatformInstrumentationEvents.cs @@ -161,41 +161,41 @@ internal class TestPlatformInstrumentationEvents /// /// The session finalization start event id. /// - public const int SessionFinalizationStartEventId = 0x40; + public const int MultiTestRunsFinalizationStartEventId = 0x40; /// /// The session finalization stop event id. /// - public const int SessionFinalizationStopEventId = 0x41; + public const int MultiTestRunsFinalizationStopEventId = 0x41; /// /// The session finalization request start event id. /// - public const int SessionFinalizationRequestStartEventId = 0x42; + public const int MultiTestRunsFinalizationRequestStartEventId = 0x42; /// /// The session finalization request stop event id. /// - public const int SessionFinalizationRequestStopEventId = 0x43; + public const int MultiTestRunsFinalizationRequestStopEventId = 0x43; /// /// The adapter session finalization start event id. /// - public const int AdapterSessionFinalizationStartEventId = 0x44; + public const int AdapterMultiTestRunsFinalizationStartEventId = 0x44; /// /// The adapter session finalization stop event id. /// - public const int AdapterSessionFinalizationStopEventId = 0x45; + public const int AdapterMultiTestRunsFinalizationStopEventId = 0x45; /// /// Events fired on session finalization start of translation layer. /// - public const int TranslationLayerSessionFinalizationStartEventId = 0x46; + public const int TranslationLayerMultiTestRunsFinalizationStartEventId = 0x46; /// /// Events fired on session finalization complete in translation layer. /// - public const int TranslationLayerSessionFinalizationStopEventId = 0x47; + public const int TranslationLayerMultiTestRunsFinalizationStopEventId = 0x47; } } \ No newline at end of file diff --git a/src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/ITestSessionEventsHandler.cs b/src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IMultiTestRunsFinalizationCompleteEventsHandler.cs similarity index 64% rename from src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/ITestSessionEventsHandler.cs rename to src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IMultiTestRunsFinalizationCompleteEventsHandler.cs index 70fde7bac3..3b18128664 100644 --- a/src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/ITestSessionEventsHandler.cs +++ b/src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IMultiTestRunsFinalizationCompleteEventsHandler.cs @@ -6,14 +6,14 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Client using System.Collections.Generic; /// - /// Interface contract for handling test session complete events + /// Interface contract for handling multi test runs finalization complete events /// - public interface ITestSessionEventsHandler : ITestMessageEventHandler + public interface IMultiTestRunsFinalizationCompleteEventsHandler : ITestMessageEventHandler { /// /// Dispatch SessionComplete event to listeners. /// /// Attachments reprocessed. - void HandleTestSessionComplete(IEnumerable attachments); + void HandleMultiTestRunsFinalizationComplete(IEnumerable attachments); } } \ No newline at end of file diff --git a/src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/OnTestSessionEndPayload.cs b/src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/MultiTestRunsFinalizationPayload.cs similarity index 75% rename from src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/OnTestSessionEndPayload.cs rename to src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/MultiTestRunsFinalizationPayload.cs index b0df025524..662c6dc6f6 100644 --- a/src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/OnTestSessionEndPayload.cs +++ b/src/Microsoft.TestPlatform.ObjectModel/Client/Payloads/MultiTestRunsFinalizationPayload.cs @@ -7,9 +7,9 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Client.Payloads using System.Runtime.Serialization; /// - /// Class used to define the OnTestSessionEndPayload sent by the Vstest.console translation layers into design mode + /// Class used to define the MultiTestRunsFinalizationPayload sent by the Vstest.console translation layers into design mode /// - public class OnTestSessionEndPayload + public class MultiTestRunsFinalizationPayload { /// /// Settings used for the discovery request. diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITranslationLayerRequestSender.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITranslationLayerRequestSender.cs index 2d7de0e0e6..c5187d6b3e 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITranslationLayerRequestSender.cs +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITranslationLayerRequestSender.cs @@ -115,7 +115,7 @@ internal interface ITranslationLayerRequestSender : IDisposable /// Provides back all attachements to TestPlatform for additional processing (for example merging) /// /// List of attachements - /// - void OnTestSessionEnd(IEnumerable attachments, ITestSessionEventsHandler testSessionEventsHandler); + /// + void FinalizeMultiTestRuns(IEnumerable attachments, IMultiTestRunsFinalizationCompleteEventsHandler multiTestRunsFinalizationCompleteEventsHandler); } } diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper2.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper2.cs index 10e4a7379a..adb48aacb7 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper2.cs +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper2.cs @@ -17,8 +17,7 @@ public interface IVsTestConsoleWrapper2 : IVsTestConsoleWrapper /// Provides back all attachements to TestPlatform for additional processing (for example merging) /// /// List of attachements - /// EventHandler to receive session complete event - void FinalizeMultiTestRuns(IEnumerable attachments, ITestSessionEventsHandler testSessionEventsHandler); - // void FinalizeTests(IEnumerable attachments, ITestSessionEventsHandler testSessionEventsHandler); + /// EventHandler to receive session complete event + void FinalizeMultiTestRuns(IEnumerable attachments, IMultiTestRunsFinalizationCompleteEventsHandler multiTestRunsFinalizationCompleteEventsHandler); } } diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.Designer.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.Designer.cs index e7fa34be5d..97fa3b3bd9 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.Designer.cs +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.Designer.cs @@ -62,11 +62,11 @@ internal Resources() { } /// - /// Looks up a localized string similar to The active Session Finalization was aborted.. + /// Looks up a localized string similar to The active Multi Test Runs Finalization was aborted.. /// - internal static string AbortedSessionFinalization { + internal static string AbortedMultiTestRunsFinalization { get { - return ResourceManager.GetString("AbortedSessionFinalization", resourceCulture); + return ResourceManager.GetString("AbortedMultiTestRunsFinalization", resourceCulture); } } diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.resx b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.resx index 882efb6704..c4dbc5499f 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.resx +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/Resources.resx @@ -117,8 +117,8 @@ System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 - - The active Session Finalization was aborted. + + The active Multi Test Runs Finalization was aborted. The active Tests Discovery was aborted. diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs index d7ae9682f3..b0085b663c 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/VsTestConsoleRequestSender.cs @@ -385,7 +385,7 @@ public void EndSession() } /// - public void OnTestSessionEnd(IEnumerable attachments, ITestSessionEventsHandler testSessionEventsHandler) + public void FinalizeMultiTestRuns(IEnumerable attachments, IMultiTestRunsFinalizationCompleteEventsHandler testSessionEventsHandler) { this.SendMessageAndListenAndReportAttachements(attachments, testSessionEventsHandler); } @@ -732,35 +732,35 @@ private async Task SendMessageAndListenAndReportTestResultsAsync(string messageT this.testPlatformEventSource.TranslationLayerExecutionStop(); } - private void SendMessageAndListenAndReportAttachements(IEnumerable attachments, ITestSessionEventsHandler eventHandler) + private void SendMessageAndListenAndReportAttachements(IEnumerable attachments, IMultiTestRunsFinalizationCompleteEventsHandler eventHandler) { try { - var payload = new OnTestSessionEndPayload + var payload = new MultiTestRunsFinalizationPayload { Attachments = attachments }; - this.communicationManager.SendMessage(MessageType.OnTestSessionEnd, payload); - var isSessionComplete = false; + this.communicationManager.SendMessage(MessageType.MultiTestRunsFinalization, payload); + var isMultiTestRunsFinalizationComplete = false; // Cycle through the messages that the vstest.console sends. // Currently each of the operations are not separate tasks since they should not each take much time. // This is just a notification. - while (!isSessionComplete) + while (!isMultiTestRunsFinalizationComplete) { var message = this.TryReceiveMessage(); - if (string.Equals(MessageType.OnTestSessionEndCallback, message.MessageType)) + if (string.Equals(MessageType.MultiTestRunsFinalizationCallback, message.MessageType)) { if (EqtTrace.IsInfoEnabled) { EqtTrace.Info("VsTestConsoleRequestSender.SendMessageAndListenAndReportAttachements: Process complete."); } - var testSessionCompletePayload = this.dataSerializer.DeserializePayload(message); + var multiTestRunsFinalizationCompletePayload = this.dataSerializer.DeserializePayload(message); - eventHandler.HandleTestSessionComplete(testSessionCompletePayload.Attachments); - isSessionComplete = true; + eventHandler.HandleMultiTestRunsFinalizationComplete(multiTestRunsFinalizationCompletePayload.Attachments); + isMultiTestRunsFinalizationComplete = true; } else if (string.Equals(MessageType.TestMessage, message.MessageType)) { @@ -772,8 +772,8 @@ private void SendMessageAndListenAndReportAttachements(IEnumerable - public void OnTestSessionEnd(IEnumerable attachments, ITestSessionEventsHandler testSessionEventsHandler) + public void FinalizeMultiTestRuns(IEnumerable attachments, IMultiTestRunsFinalizationCompleteEventsHandler testSessionEventsHandler) { this.EnsureInitialized(); - this.requestSender.OnTestSessionEnd(attachments, testSessionEventsHandler); - this.requestSender.FinalizeSession(attachments, testSessionEventsHandler); + this.requestSender.FinalizeMultiTestRuns(attachments, testSessionEventsHandler); } #endregion