Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ALL_PROCESSOR_GROUPS is u32, while should be u16 #1680

Closed
klensy opened this issue Aug 15, 2023 · 2 comments
Closed

Bug: ALL_PROCESSOR_GROUPS is u32, while should be u16 #1680

klensy opened this issue Aug 15, 2023 · 2 comments
Labels
bug Something isn't working rust Critical for Rust adoption

Comments

@klensy
Copy link

klensy commented Aug 15, 2023

Which crate is this about?

windows

Crate version

0.48.0

Summary

Type of constant https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/System/SystemServices/constant.ALL_PROCESSOR_GROUPS.html used in crate is u32

while it should be u16 https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getactiveprocessorcount

Found while implemented rust-lang/rust#114856

Toolchain version/configuration

No response

Reproducible example

No response

Crate manifest

No response

Expected behavior

No response

Actual behavior

No response

Additional comments

I believe this is https://github.com/microsoft/windows-rs/blob/78a0dbea48f856b03f3e7e650e0e385047d8a10b/crates/libs/windows/src/Windows/Win32/System/SystemServices/mod.rs#L124

Actually in rust repo used windows-bindgen 0.49, but i think that there used the same definition.

Probably affects other crates that reimports that definition.

@kennykerr
Copy link
Contributor

Thanks, will forward to the Win32 metadata repo for resolution.

@kennykerr kennykerr transferred this issue from microsoft/windows-rs Aug 15, 2023
@riverar riverar added the rust Critical for Rust adoption label Aug 15, 2023
@klensy
Copy link
Author

klensy commented Aug 16, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rust Critical for Rust adoption
Projects
None yet
Development

No branches or pull requests

3 participants