Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send and Sync for Weak reference #3137

Closed
lifers opened this issue Jun 29, 2024 · 1 comment · Fixed by #3138
Closed

Send and Sync for Weak reference #3137

lifers opened this issue Jun 29, 2024 · 1 comment · Fixed by #3138
Labels
enhancement New feature or request

Comments

@lifers
Copy link
Contributor

lifers commented Jun 29, 2024

Suggestion

Is there any danger in assuming Send and Sync for types that contain windows_core::Weak? In comparison, std::sync::Weak is Send and Sync.

If it's safe, I'd like it to be implemented directly in the windows_core::Weak definition. Thanks!
@lifers lifers added the enhancement New feature or request label Jun 29, 2024
@kennykerr kennykerr mentioned this issue Jul 1, 2024
Merged
@kennykerr
Copy link
Collaborator

Yep, IWeakReference and IWeakReferenceSource are designed and implemented to be completely thread safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Send and Sync for Weak<T> microsoft/windows-rs
2 participants
@kennykerr @lifers