Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Microsoft.WinGet.Client PowerShell cmdlets "singular" in name #4680

Closed
denelon opened this issue Jul 26, 2024 · 4 comments · Fixed by #4716
Closed

Make Microsoft.WinGet.Client PowerShell cmdlets "singular" in name #4680

denelon opened this issue Jul 26, 2024 · 4 comments · Fixed by #4716
Labels
In-PR Issue related to a PR Issue-Feature This is a feature request for the Windows Package Manager client. PowerShell Issue related to WinGet PowerShell Module or cmdlet
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Jul 26, 2024

Description of the new feature / enhancement

The following cmdlets are plural in name and should be singular:

  • Get-WinGetSettings
  • Get-WinGetUserSettings
  • Set-WinGetUserSettings
  • Test-WinGetUserSettings

Proposed technical implementation details

No response

@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. PowerShell Issue related to WinGet PowerShell Module or cmdlet labels Jul 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage Issue need to be triaged and removed Needs-Triage Issue need to be triaged labels Jul 26, 2024
@denelon
Copy link
Contributor Author

denelon commented Jul 29, 2024

These should be made into "singular" names, and the "plural" name should become an alias so users who have scripted against this aren't broken.

@jantari
Copy link

jantari commented Aug 1, 2024

[...] the "plural" name should become an alias so users who have scripted against this aren't broken.

F*** 'em. Break it now while it's still fresh, you don't wanna become the ShellFolders of the 21st century. No alias!

@kilasuit
Copy link
Contributor

kilasuit commented Aug 9, 2024

@denelon I'll add this into the following PR #4716

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR Issue related to a PR label Aug 9, 2024
@ThomasNieto
Copy link

There is an anti-pattern when putting all "settings" into a single cmdlet. Ideally there would be a cmdlet(s) to set the individual setting.

Here are some examples that aren't real WinGet values.

Disable-WinGetHashValidation
Enable-WinGetHashValidation

Set-WinGetTimeout
Get-WinGetTimeout

Lets take Get-WinGetSettings cmdlet. The output is not user friendly at all. First it returns a case sensitive hashtable. The is not a good way to parse the settings at a glance. There is not an easy way for me to determine which settings I can set with Set-WinGetSettings since it takes a hashtable which could be anything.

@denelon denelon added this to the 1.9 Client milestone Oct 10, 2024
@denelon denelon added this to WinGet Oct 22, 2024
@denelon denelon moved this to Done in WinGet Oct 22, 2024
@denelon denelon moved this from Done to Released in WinGet Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Issue related to a PR Issue-Feature This is a feature request for the Windows Package Manager client. PowerShell Issue related to WinGet PowerShell Module or cmdlet
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants