-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture override option to Update command #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
label
Nov 24, 2021
palenshus
reviewed
Nov 24, 2021
palenshus
reviewed
Nov 24, 2021
palenshus
reviewed
Nov 24, 2021
palenshus
reviewed
Nov 24, 2021
palenshus
reviewed
Nov 24, 2021
palenshus
previously requested changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
ghost
added
the
Needs-Author-Feedback
label
Nov 24, 2021
ghost
removed
the
Needs-Author-Feedback
label
Nov 29, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
reviewed
Nov 30, 2021
palenshus
requested changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
ghost
added
the
Needs-Author-Feedback
label
Dec 1, 2021
ghost
removed
the
Needs-Author-Feedback
label
Dec 1, 2021
palenshus
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198
This PR addresses issues that some users have been having with the update command detecting the wrong architecture from the installers they provide when trying to use the update command. This discrepancy is often seen in nullsoft installers, which are detected to be x86 based off their installer executables, even if they install a x64 application.
To resolve this, we added the ability for users to append the overriding architecture to the end of the installerURL they are updating with. The architecture must be separated by the '|' character with no spaces.
Example (overriding x64 installer with x86):
wingetcreate update -u https://foobar_x64_installer.exe|x86
Changes:
Testing:
Added 5 unit tests to verify the functionality of this new features:
Microsoft Reviewers: Open in CodeFlow