Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Property editor improvements. #174

Merged
merged 2 commits into from
Jan 19, 2018
Merged

Property editor improvements. #174

merged 2 commits into from
Jan 19, 2018

Conversation

lewing
Copy link
Member

@lewing lewing commented Jan 19, 2018

This fixes a couple of corner cases in for our representations in the property editor.

  • For some properties we return messages not values, render those.
  • The generic cast can fail where our representation has a padded value. Use Convert.ChangeType instead.

@lewing
Use Convert.ChangeType rather than the generic cast
ea0c1a8 
We want to use a valid conversion here
so don't just cast using the generic type.
@lewing
Go ahead and use string values when we've coerced them
9bbc500
abock
abock approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@abock abock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

sandyarmstrong
sandyarmstrong approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@sandyarmstrong sandyarmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@abock
Copy link
Contributor

abock commented Jan 19, 2018

build

@abock abock merged commit 7bf23b5 into microsoft:master Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandyarmstrong sandyarmstrong sandyarmstrong approved these changes

@abock abock abock approved these changes

@bojanrajkovic bojanrajkovic Awaiting requested review from bojanrajkovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @abock @sandyarmstrong