Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content range order during upload #304

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jul 8, 2024

Overview

Fixes #295

Content Range order needs to be submitted in order

Testing

  • Added check in unit test

@rkodev rkodev requested a review from a team as a code owner July 8, 2024 09:52
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a changelog entry and I think we should be good to go here.

@calebkiage
Copy link

@baywet, the release bot should take care of changelog entries.

@rkodev
Copy link
Contributor Author

rkodev commented Jul 10, 2024

@baywet we have enabled release please in the repo

@baywet baywet force-pushed the fix/large-file-upload branch from f65cad1 to 41acc05 Compare July 10, 2024 11:54
@baywet baywet enabled auto-merge (squash) July 10, 2024 11:54
@baywet baywet disabled auto-merge July 10, 2024 11:54
@baywet baywet enabled auto-merge (squash) July 10, 2024 11:54
@baywet
Copy link
Member

baywet commented Jul 10, 2024

Thank you both for updating the configuration. I updated my review of this pull request.

Copy link

@baywet baywet merged commit f241e94 into main Jul 10, 2024
8 checks passed
@baywet baywet deleted the fix/large-file-upload branch July 10, 2024 11:56
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large file upload failing with "The Content-Range header length does not match the provided number of bytes."
4 participants