Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot retrieve cell value when column or row are zero #795

Closed
3miliano opened this issue Jul 2, 2024 · 1 comment · Fixed by microsoft/kiota#5119
Closed

Cannot retrieve cell value when column or row are zero #795

3miliano opened this issue Jul 2, 2024 · 1 comment · Fixed by microsoft/kiota#5119
Assignees
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience

Comments

@3miliano
Copy link

3miliano commented Jul 2, 2024

Describe the bug

You cannot retrieve a cell value when row or column are zero since there is a if not check that prevents the call to go thru.

        """
        Provides operations to call the cell method.
        param column: Usage: column={column}
        param row: Usage: row={row}
        Returns: CellWithRowWithColumnRequestBuilder
        """
        if not column:
            raise TypeError("column cannot be null.")
        if not row:
            raise TypeError("row cannot be null.")
        from .cell_with_row_with_column.cell_with_row_with_column_request_builder import CellWithRowWithColumnRequestBuilder

        return CellWithRowWithColumnRequestBuilder(self.request_adapter, self.path_parameters, column, row)

Expected behavior

The call should support zeros since indexing of columns and rows are zero-based.

How to reproduce

client.drives.by_drive_id(drive_id).items.by_drive_item_id(item_id).workbook.worksheets.by_workbook_worksheet_id(worksheet_id).cell_with_row_with_column(0, 0).get()

SDK Version

1.4.0

Latest version known to work for scenario above?

No response

Known Workarounds

None

Debug output

column = 23, row = 0

    def cell_with_row_with_column(self,column: int, row: int) -> CellWithRowWithColumnRequestBuilder:
        """
        Provides operations to call the cell method.
        param column: Usage: column={column}
        param row: Usage: row={row}
        Returns: CellWithRowWithColumnRequestBuilder
        """
        if not column:
            raise TypeError("column cannot be null.")
        if not row:
>           raise TypeError("row cannot be null.")
E           TypeError: row cannot be null.

Configuration

OS: macOS Sonoma
Arch: ARM64

Other information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants