-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate in the UI what media cannot be played and media that can be played but with no audio #209
Comments
Hi, thanks for your detailed query and providing helpful info. I'll look into this further and get back to you. In the meantime, what client were you using? Currently Midarr has no context or knowledge of what client is requesting the media. So it sends the media files regardless of whether the client can actually play it or not. Knowing what client you used will serve as a baseline as to what it supports. |
I'm using chrome on MacOS, it does appear chrome does not support AC3 |
Thanks for reporting back. Yes it appears Chrome does not support AC3 due to codec licensing. |
I think it would be hugely beneficial to support some form of audio transcoding from a server perspective. I am rather hesitant on having Midarr be client aware - as I feel this would be a huge maintenance burden going forward (having to maintain a list of client profiles and what each one supports for example). As a first step to an improvement over Midarr just blindly serving media files - there could be an admin setting on the settings page for the audio output to be configured / adjusted. So at a server baseline, Midarr could transcode on-the-fly all audio - to MP3 for example - no matter what codec the media audio is in, based on this setting. I think this would be a good first step to improving Midarr's playback abilities, and opens the door for future improvements. For example an admin could map a list of clients - to their preferred media settings, which in turn alleviates Midarr of the responsibility and puts it onto the server maintainers themselves. Just some ideas - what do you think? I'd be interested to hear your thoughts, as we have the same issue. I've had to curate my media library so my clients can play them. If Midarr handled some of this for me (like the audio for example), I wouldn't have to ensure my media library could be played in Chrome. |
Chrome could be getting ac3 support in the future but overall it's probably not best to wait. Having audio transcoded would be a huge benefit as most of my library is h264 video with mixed audio. |
https://bitmovin.com/google-adds-hevc-support-chrome/ Interestingly, Google also just recently (and quietly) added HEVC / H.265 video support. You can play this media content now natively from Midarr in Chrome / Edge / Safari. I have yet to update the Readme to reflect this, but yes it now just leaves the audio to be transcoded for these clients. |
I've added an issue to address this. I'll look into this for |
Hi @onedr0p Thanks for your feedback once again! |
Give this build a go 😄 You'll find a new "Test" button, next to the "Play" button for your media. The "Test" button transcodes your media on the fly (currently to AAC audio 2 channels / stereo). Playback is still a little rough / flashy between segments, but it is a start. I'll improve playback over time. If you try playing this video again - it should have audio this time 🤞
|
https://github.com/midarrlabs/midarr-server/discussions/292 @onedr0p special thanks for helping with this release. |
I really get the simple approach to Midarr but there's some UX issues in regards to unplayable media. I have a mixed collection of Movies and TV shows and it appears hit or miss if the media will play, or if it does play there's no audio. Maybe Midarr is not for me because I haven't really curated my media in such a standard for Midarr to play all the things but we'll see 😄
Here's an example of what will play but has no audio (
AC3 5.1
):The text was updated successfully, but these errors were encountered: