From c24a7c35c4838b164b1605c48f7fd437d4c4e71c Mon Sep 17 00:00:00 2001 From: Patrick Reynolds Date: Mon, 1 Feb 2016 16:06:25 -0500 Subject: [PATCH] Fixing some more documentation issues. --- modules/tracker/models/base/SubmissionModelBase.php | 8 ++++---- modules/tracker/models/pdo/SubmissionModel.php | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/modules/tracker/models/base/SubmissionModelBase.php b/modules/tracker/models/base/SubmissionModelBase.php index c349b452d..392a55df1 100644 --- a/modules/tracker/models/base/SubmissionModelBase.php +++ b/modules/tracker/models/base/SubmissionModelBase.php @@ -95,10 +95,10 @@ abstract public function getScalars($submissionDao, $key = false); * Get the single latest submission associated with a given producer. * * @param Tracker_ProducerDao $producerDao producer DAO - * @param false | string $date the latest time end the 24-hour interval or false to use the current day. + * @param false | string $date the end of the interval or false to use 23:59:59 of the current day * @param string $branch the branch of the submission for which to search - * @param bool $onlyOneDay true to return submissions 24 hours back from $date, false otherwise. In the case of the - * of $date === false, $onlyOneDay will search only in the current day. + * @param bool $onlyOneDay if true return submissions 24 hours back from $date, false otherwise. In the case of + * $date === false, search only in the current day * @return false | Tracker_SubmissionDao submission */ abstract public function getLatestSubmissionByProducerDateAndBranch($producerDao, @@ -110,7 +110,7 @@ abstract public function getLatestSubmissionByProducerDateAndBranch($producerDao * Get trends associated with a submission. * * @param Tracker_SubmissionDao $submissionDao submission DAO - * @param bool $key true if only key trends should be returned, false otherwise. + * @param bool $key true if only key trends should be returned, false otherwise * @return array Tracker_TrendDaos */ abstract public function getTrends($submissionDao, $key = true); diff --git a/modules/tracker/models/pdo/SubmissionModel.php b/modules/tracker/models/pdo/SubmissionModel.php index 2dc9c60ee..c9637cc15 100644 --- a/modules/tracker/models/pdo/SubmissionModel.php +++ b/modules/tracker/models/pdo/SubmissionModel.php @@ -157,10 +157,10 @@ public function getOrCreateSubmission($producerDao, $uuid) * Get the single latest submission associated with a given producer. * * @param Tracker_ProducerDao $producerDao producer DAO - * @param false | string $date the latest time end the 24-hour interval or false to use the current day. + * @param false | string $date the end of the interval or false to use 23:59:59 of the current day * @param string $branch the branch of the submission for which to search - * @param bool $onlyOneDay true to return submissions 24 hours back from $date, false otherwise. In the case of the - * of $date === false, $onlyOneDay will search only in the current day. + * @param bool $onlyOneDay if true return submissions 24 hours back from $date, false otherwise. In the case of + * $date === false, search only in the current day * @return false | Tracker_SubmissionDao submission */ public function getLatestSubmissionByProducerDateAndBranch($producerDao, $date = false, $branch = 'master', @@ -178,7 +178,7 @@ public function getLatestSubmissionByProducerDateAndBranch($producerDao, $date = 'tracker_scalar', 'tracker_submission.submission_id = tracker_scalar.submission_id', array()) - ->where('tracker_submission.submit_time < ?', $queryTime); + ->where('tracker_submission.submit_time <= ?', $queryTime); if ($onlyOneDay) { $sql = $sql->where('tracker_submission.submit_time > ?', $dayBeforeQueryTime); } @@ -200,7 +200,7 @@ public function getLatestSubmissionByProducerDateAndBranch($producerDao, $date = * Get trends associated with a submission. * * @param Tracker_SubmissionDao $submissionDao submission DAO - * @param bool $key true if only key trends should be returned, false otherwise. + * @param bool $key true if only key trends should be returned, false otherwise * @return array Tracker_TrendDaos */ public function getTrends($submissionDao, $key = true)