Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Lossless keyframe," rather than "Nearest keyframe" #167

Closed
Rehaan13 opened this issue Jun 2, 2019 · 5 comments
Closed

"Lossless keyframe," rather than "Nearest keyframe" #167

Rehaan13 opened this issue Jun 2, 2019 · 5 comments

Comments

@Rehaan13
Copy link

Rehaan13 commented Jun 2, 2019

Awesome program, thanks!

Rather than jumping to the nearest keyframe (which means the selected segment might LOSE out on a few frames/second of footage), could you:

  1. Select the nearest EARLIER keyframe for the IN point
  2. Select the nearest LATER keyframe for the OUT point

This would prevent users from losing out on an important bit of footage when chopping up their files in LosslessCut.

Better to have an extra few seconds than a few seconds less!

@Rehaan13
Copy link
Author

Rehaan13 commented Jun 5, 2019

Adding to this idea...

Have the option to buffer cuts with "X" number of additional frames / seconds.

Eg. If i'm using this software to cut up raw clips before taking them into Premiere for an edit, I'd like some additional lead-in / out for transitions, leeway, etc.

If i could set an options like "Save an additional ____ seconds before & after each selected clip" - that would be amazing.

@mifi
Copy link
Owner

mifi commented Jun 5, 2019

I agree! Have not yet implemented parsing of keyframes because it turns out to be a bit slow operation. But we could like you say work around it by adding a few sec before/after cut. Just need to determine how many sec..

@Rehaan13
Copy link
Author

Rehaan13 commented Jun 5, 2019

Just need to determine how many sec..

I think users use your program for many different reasons. Some want exact cuts, while others want to just trim a few gigabytes off their raw video, and then import the result into an editing program.

I think having "Settings" in the program with options like these (eg. closest keyframe outside the selection vs add X seconds buffer) would be a good start, and way for the future to cater to many use-cases.

@mifi
Copy link
Owner

mifi commented Feb 22, 2020

After some experimentation it seems that the current behavior when using "keyframe cut", is indeed that it will jump to the nearest keframe before the desired cutpoint, so you will not lose anything.
The newest version now shows keyframes on the timeline and lets you zoom in. so you can experiment with cutting near keyframes.

@mifi
Copy link
Owner

mifi commented May 3, 2020

See #330

@mifi mifi closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants