Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't drop Windows 32-bit support #217

Closed
txr660 opened this issue Nov 6, 2019 · 4 comments
Closed

Please don't drop Windows 32-bit support #217

txr660 opened this issue Nov 6, 2019 · 4 comments

Comments

@txr660
Copy link

txr660 commented Nov 6, 2019

Please continue building the 32-bit package for Windows .
I started using Lossless-cut only last year and I have been using it a lot since .
Thanks

@mifi
Copy link
Owner

mifi commented Feb 11, 2020

im not quite sure how to easily do that with the newest build system based on electron builder. Need to include the correct ffmpeg binary depending on whether build is 32/64bit. if someone has some easy solution please shout out.

@mifi
Copy link
Owner

mifi commented Mar 4, 2020

Now I think we can easily add 32 bit win support again, but I'm not sure how many people want that

@mifi
Copy link
Owner

mifi commented Mar 6, 2020

I tried to implement 32 bit in the branch https://github.com/mifi/lossless-cut/tree/32bit

It seems to work, and it generates two builds. And for ffprobe it includes the right 64/32 bit version, but ffmpeg-static which now downloads only the version for the current arch only, it won't let me select which one to be included in the electron-builder.
See eugeneware/ffmpeg-static#35

I'm thinking maybe creating a new npm module that works like ffmpeg-static used to work before.

@mifi
Copy link
Owner

mifi commented Jan 14, 2022

I'm going to close this. Unfortunately I will probably never prioritize this

@mifi mifi closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants