Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add full lavcodec support for decoding and DXVA2 for displaying videos #2292

Closed
4 tasks done
AmBintroGoof99 opened this issue Jan 10, 2025 · 1 comment
Closed
4 tasks done

Comments

@AmBintroGoof99
Copy link

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

Hi! First of all, I’d like to thank the owner/developer of this program for the wonderful work. LosslessCut is one of my most favorite programs to cut and trim videos with. And one thing I especially like about it is that it supports pretty much every format that FFmpeg does, including preserving Dolby E audio tracks on .ts and .mxf files. No other program does that as seamlessly and as smoothly as LosslessCut does.

However, the HTML5 player on LC is limiting the app so much and making it often very hard to use due to the horrid playback when seeking files, even when they are “compatible” formats. PLEASE, if it is possible (am pretty sure it is) ditch it in favor of full-blown lavcodec decoding and DXVA2 display support as default instead. Avidemux does this, and videos play back buttery smooth even on very slow computers. I think this may even fix the issue where LC was either a frame behind or ahead in comparison to Avidemux and VirtualDub2, which can cause inaccurate cuts. If this is implemented, LosslessCut will really be able to compete with programs like VideoReDo because it’s already so great, but lacks this feature and a couple more.

Thanks again for everything, and I hope this makes it to the next release.

@mifi
Copy link
Owner

mifi commented Jan 11, 2025

Hi and thanks for your feedback. This has been discussed before (#88), but the problem is that I haven't found an easy way to replace the HTML5 player with anything with a similar API. However in Electron/Chromium, the HTML5 video player already uses lavcodec for playback. As I understood it, the problem is that it has been compiled only to support certain codecs and formats (those that are open source compatible, e.g. no patents etc). So it would be theoretically possible to re-compile Electron and include a lot of extra codecs for playback, however practically I don't know how to achieve that. A lot of other people want this too, but nobody has yet found a solution:

If someone want to look into it, then I'm open to setting up a custom Electron build system, but I don't have the resources or knowledge to work on that unfortunately. So there's nothing actionable here for me so I'm going to close this.

@mifi mifi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants