Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generated TODOs #9

Open
mateusoliveira43 opened this issue Mar 1, 2024 · 2 comments
Open

Remove generated TODOs #9

mateusoliveira43 opened this issue Mar 1, 2024 · 2 comments
Assignees
@mateusoliveira43

Comments

@mateusoliveira43
Copy link
Contributor

kubebuilder creates TODOs in code. Fix them and remove them.

To find them, run grep -Inr 'TODO(user)' .
@kaovilai
Copy link
Member

kaovilai commented Mar 1, 2024

Not sure if this is related to kubernetes-sigs/controller-tools#877 or not.

@mateusoliveira43 mateusoliveira43 self-assigned this Sep 8, 2024
@mateusoliveira43
Copy link
Contributor Author

@kaovilai no, different thing

We just need to remove comments from deployment yaml generated for us, for example

oadp-non-admin/config/manager/manager.yaml

Line 39 in 4b2f57f

# TODO(user): Uncomment the following code to configure the nodeAffinity expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateusoliveira43 mateusoliveira43

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaovilai @mateusoliveira43